Commitd9f820a

committed

fix($sceDelegate): makeresourceUrlWhitelist() is identicaltrustedResourceUrlList()

In commita206e26, `$sceDelegateProvider`'s`resourceUrlWhitelist()` was deprecated in favor of the new`trustedResourceUrlList()`. However, although both properties wereassigned the same value, it was possible for an app to break if one ofthe properties was overwritten in one part of the app (or a 3rd-partylibrary) while another part of the app interacts with the other,non-overwritten property.This commit fixes it by making `resourceUrlWhitelist()` a getter/setterthat delegates to `trustedResourceUrlList()`, ensuring that the twoproperties will remain in sync. This, also, makes it consistent withother similar deprecated properties, such as `$sceDelegateProvider`'s`resourceUrlBlacklist()`.Closes#17090

1 parent5e85ef3 commitd9f820aCopy full SHA for d9f820a

File tree

1 file changed

+20

-1

lines changed

src/ng
- sce.js

1 file changed

+20

-1

lines changed

`‎src/ng/sce.js`

Lines changed: 20 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,26 @@ function $SceDelegateProvider() {`
`215`	`215`	`}`
`216`	`216`	`returntrustedResourceUrlList;`
`217`	`217`	`};`
`218`		`-this.resourceUrlWhitelist=this.trustedResourceUrlList;`
	`218`	`+`
	`219`	`+/**`
	`220`	`+ *@ngdoc method`
	`221`	`+ *@name $sceDelegateProvider#resourceUrlWhitelist`
	`222`	`+ *@kind function`
	`223`	`+ *`
	`224`	`+ *@deprecated`
	`225`	`+ * sinceVersion="1.8.1"`
	`226`	`+ *`
	`227`	`+ * This method is deprecated. Use {@link $sceDelegateProvider#trustedResourceUrlList`
	`228`	`+ * trustedResourceUrlList} instead.`
	`229`	`+ */`
	`230`	`+Object.defineProperty(this,'resourceUrlWhitelist',{`
	`231`	`+get:function(){`
	`232`	`+returnthis.trustedResourceUrlList;`
	`233`	`+},`
	`234`	`+set:function(value){`
	`235`	`+this.trustedResourceUrlList=value;`
	`236`	`+}`
	`237`	`+});`
`219`	`238`
`220`	`239`	`/**`
`221`	`240`	`*@ngdoc method`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd9f820a

File tree

1 file changed

1 file changed

`‎src/ng/sce.js`

0 commit comments