Commit91a91b6

committed

fix(ngMock): Don't clean up if currentSpec is null.

In unit tests that use Angular and AngularJS, sometimes an error beingthrown during the test and cause this afterEach hook to run twice. Ifthat happens, on the second run cleanup will throw an error, since atthat point currentSpec is null. This causes the original error to behidden by a "TypeError: Cannot read property '$injector' of null whiletesting" error.This makes cleanup safe to call multiple times, working around theissue.

1 parent33b5c50 commit91a91b6Copy full SHA for 91a91b6

File tree

1 file changed

-0

lines changed

src/ngMock
- angular-mocks.js

1 file changed

-0

lines changed

`‎src/ngMock/angular-mocks.js`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3000,6 +3000,9 @@ angular.mock.$RootScopeDecorator = ['$delegate', function($delegate) {`
`3000`	`3000`	`};`
`3001`	`3001`
`3002`	`3002`	`module.$$cleanup=function(){`
	`3003`	`+if(!currentSpec){`
	`3004`	`+return;`
	`3005`	`+}`
`3003`	`3006`	`varinjector=currentSpec.$injector;`
`3004`	`3007`
`3005`	`3008`	`annotatedFunctions.forEach(function(fn){`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit91a91b6

File tree

1 file changed

1 file changed

`‎src/ngMock/angular-mocks.js`

0 commit comments