- Notifications
You must be signed in to change notification settings - Fork11.9k
build: update to TypeScript 5.9 beta#30740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
425da03 tocf0806cCompareUpdates the repo to the TypeScript 5.9 beta and widens the peer dependency ranges.
| @@ -149,12 +149,12 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => { | |||
| [ | |||
| async () => { | |||
| // Add invalid block syntax | |||
| await harness.appendToFile('src/app/app.component.html', '@one'); | |||
| await harness.appendToFile('src/app/app.component.html', '@if-one'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had to change this test, because in the latest version Angular is a bit more permissive about parsing unsupported blocks.
| @@ -38,11 +38,15 @@ export function subscribeToWorkflow( | |||
| ); | |||
| break; | |||
| case'update': | |||
| logs.push(`${colors.cyan('UPDATE')}${eventPath} (${event.content.length} bytes)`); | |||
| logs.push( | |||
| `${colors.cyan('UPDATE')}${eventPath} (${(event.contentasunknownasBuffer).length} bytes)`, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does not seem ideal from a type safety perspective.
Is there some information/context on the changes needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So as far as I could tell, the types didn't really change but TS is being better at enforcing them. I did start to update the types, but it ended up spanning a ton of files so decided to keep the change simple for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok. makes sense.
Can you add some TODOs in there so we can clean this up later on?
Updates the repo to the TypeScript 5.9 beta and widens the peer dependency ranges.