- Notifications
You must be signed in to change notification settings - Fork11.9k
fix(@angular/ssr): check whether injector is destroyed#30738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
arturovt wants to merge1 commit intoangular:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+6 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
In this commit, we check whether the injector is destroyed before calling to `envInjector.get`. The application might be destroyed and `whenStable()` would resolve immediately; as thus, calling to `injector.get` is unsafe and should be guarded.
| constrouterIsProvided=!!envInjector.get(ActivatedRoute,null); | ||
| constrouter=envInjector.get(Router); | ||
| constlastSuccessfulNavigation=router.lastSuccessfulNavigation; | ||
| constrouterIsProvided=destroyed ?false :!!envInjector.get(ActivatedRoute,null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the case when the applicationRef gets destroyed before the rendering phase? Internally in
| renderInternal(platformRef,applicationRef) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
action: reviewThe PR is still awaiting reviews from at least one requested reviewer area: @angular/ssr
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we check whether the injector is destroyed before calling to
envInjector.get. The application might be destroyed andwhenStable()would resolve immediately; as thus, calling toinjector.getis unsafe and should be guarded.