- Notifications
You must be signed in to change notification settings - Fork11.9k
Commitd19f260
fix(@angular-devkit/build-angular): avoid undefined module path for Sass imports in esbuild
When using Sass with the experimental esbuild-based browser application builder, bare importswithout a path segment that were available via included paths but also happen to be a node modulecould cause an exception. An example of such an import would be `@import "globals";`. The deepimport node module logic would previously attempt to join an undefined path segment to the resolvedpath for the `globals` package which would raise a argument type exception. This case has now beenfixed by only joining if there is actually a path segment present such as `@import "globals/x"`.With this fix in place, the node module case can then continue and if no stylesheet is found, theinclude paths will then be searched.1 parentb5737ef commitd19f260
File tree
1 file changed
+5
-1
lines changed- packages/angular_devkit/build_angular/src/builders/browser-esbuild
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
128 | 132 | | |
129 | 133 | | |
130 | 134 | | |
| |||
0 commit comments
Comments
(0)