NotificationsYou must be signed in to change notification settings
Fork12k
Star26.9k

Commit525ddcb

committed

fix(@schematics/angular): only overwrite JSON file if actually changed

The JSON file helper utility used within the Angular schematics nowcontains additional checks when attempting to modify a file to avoidoverwriting a file if no actual changes will occur after a modify request.(cherry picked from commit664e6c7)

1 parente5efdc5 commit525ddcbCopy full SHA for 525ddcb

File tree

1 file changed

+10

-3

lines changed

packages/schematics/angular/utility
- json-file.ts

1 file changed

+10

-3

lines changed

`‎packages/schematics/angular/utility/json-file.ts`

Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,9 +95,16 @@ export class JSONFile {`
`95`	`95`	`},`
`96`	`96`	`});`
`97`	`97`
`98`		`-this.content=applyEdits(this.content,edits);`
`99`		`-this.host.overwrite(this.path,this.content);`
`100`		`-this._jsonAst=undefined;`
	`98`	`+if(edits.length>0){`
	`99`	`+consteditedContent=applyEdits(this.content,edits);`
	`100`	`+`
	`101`	`+// Update the file content if it changed`
	`102`	`+if(editedContent!==this.content){`
	`103`	`+this.content=editedContent;`
	`104`	`+this.host.overwrite(this.path,editedContent);`
	`105`	`+this._jsonAst=undefined;`
	`106`	`+}`
	`107`	`+}`
`101`	`108`	`}`
`102`	`109`
`103`	`110`	`remove(jsonPath:JSONPath):void{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit525ddcb

File tree

1 file changed

1 file changed

`‎packages/schematics/angular/utility/json-file.ts`

0 commit comments