Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(docs-infra): fix typos in Effects doc in Signals guide#66152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
da70 wants to merge1 commit intoangular:main
base:main
Choose a base branch
Loading
fromda70:fix-typos-in-signals-guide-effects-doc

Conversation

@da70
Copy link

@da70da70 commentedDec 17, 2025
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robotangular-robotbot added area: docsRelated to the documentation area: docs-infraAngular.dev application and infrastructure labelsDec 17, 2025
@ngbotngbotbot added this to theBacklog milestoneDec 17, 2025
Copy link
Member

@JeanMecheJeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this. Can you make sure to sign the CLA. Thank you.

@da70
Copy link
Author

Sorry, I didn't see the CLA requirement. I'm not sure yet if I can sign it. I will need to talk to my employer first.

Alternatively you could apply the changes yourself under your username. I wouldn't mind.

@michael-small
Copy link
Contributor

While you have this open, if you don't mind, I noticed that the existing doc has two subtle typos in the code block under "## Side effects on DOM elements"

afterNextRender({write:()=>{// there is no "nativeElement", and missing "t" in "this.charData"this.chart=initializeChart(this.nativeElement(),this.charData());},});

should be

afterNextRender({write:()=>{this.chart=initializeChart(this.canvas(),this.chartData());},});

@alan-agius4alan-agius4 removed their request for reviewDecember 18, 2025 07:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JeanMecheJeanMecheJeanMeche approved these changes

Assignees

No one assigned

Labels

area: docsRelated to the documentationarea: docs-infraAngular.dev application and infrastructurecla: no

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@da70@michael-small@JeanMeche

[8]ページ先頭

©2009-2025 Movatter.jp