- Notifications
You must be signed in to change notification settings - Fork27k
docs(docs-infra): fix typos in Effects doc in Signals guide#66152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JeanMeche left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this. Can you make sure to sign the CLA. Thank you.
da70 commentedDec 17, 2025
Sorry, I didn't see the CLA requirement. I'm not sure yet if I can sign it. I will need to talk to my employer first. Alternatively you could apply the changes yourself under your username. I wouldn't mind. |
michael-small commentedDec 18, 2025
While you have this open, if you don't mind, I noticed that the existing doc has two subtle typos in the code block under "## Side effects on DOM elements" afterNextRender({write:()=>{// there is no "nativeElement", and missing "t" in "this.charData"this.chart=initializeChart(this.nativeElement(),this.charData());},}); should be afterNextRender({write:()=>{this.chart=initializeChart(this.canvas(),this.chartData());},}); |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information