- Notifications
You must be signed in to change notification settings - Fork27k
feat(router): Publish Router's integration with platform Navigation API as experimental#66140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
atscott wants to merge1 commit intoangular:mainChoose a base branch fromatscott:publishexpnavfeature
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6e8d235 to109bc0fCompare…PI as experimentalThis publishes the work that was done to integrate with the NavigationAPI as an experimental router feature. Browser support is limited and inactive development. There are also known bugs in the browser implementationsand only Chromium browsers supported deferred URL updates with the`precommitHandler`. Relates toangular#53321, which I would likely not mark ascompleted until this is at least in dev preview, which likely won'thappen until it is widely available and potentially delayed until`precommitHandler` is widely available as well.The final form of this api might not even be a "router feature" in the end, but instead besomething similar to what other frameworks have to provide differentplatform integrations (e.g. `provideNavigationRouter`). That wouldsupport omitting the history-based integration from the bundle when onlythe navigation integration is used. Alternatively, the current`provideRouter` could require one of `withHistory` or `withPlatformNavigation`.
109bc0f to8f17ab8CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This publishes the work that was done to integrate with the Navigation API as an experimental router feature. Browser support is limited and in active development. There are also known bugs in the browser implementations and only Chromium browsers supported deferred URL updates with the
precommitHandler. Relates to#53321, which I would likely not mark as completed until this is at least in dev preview, which likely won't happen until it is widely available and potentially delayed untilprecommitHandleris widely available as well.The final form of this api might not even be a "router feature" in the end, but instead be something similar to what other frameworks have to provide different platform integrations (e.g.
provideNavigationRouter). That would support omitting the history-based integration from the bundle when only the navigation integration is used. Alternatively, the currentprovideRoutercould require one ofwithHistoryorwithPlatformNavigation.