- Notifications
You must be signed in to change notification settings - Fork27k
refactor(router): Change RouterLink internals to use signals#65886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This simplifies some of the internals of RouterLink because signals dothe heavy lifting of determining when things have changed
801e7b6 tofe701d7CompareContributorAuthor
atscott commentedDec 8, 2025
Closing. There is little actual benefit from doing this but it ends up being breaking for tests because people love to mock the Router. Until there is a measurable impact on size or function, this change doesn't make sense. |
This was referencedDec 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies some of the internals of RouterLink because signals do the heavy lifting of determining when things have changed