refactor(signal-forms): rework metadata API#62713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

base:prototype/signal-forms

Choose a base branch

Open

+235 −306

Conversation

Copy link

Contributor

Note: each commit is an independently reviewable step if you prefer to review commit-by-commit.

I still have a few open questions:

Do we prefer the namemetadata orproperty for this concept?
What should be the names of the functions used to bind logic toMetadataKey andAggregateMetadataKey.
Some ideas forMetadataKey include:
- metadata (orproperty)
- setMetadata (orsetProperty)
Some ideas forAggregateMetadataKey include:
- addMetadata (oraddProperty)
- addToMetadata (oraddToProperty)
- aggregateMetadata (oraggregateProperty)
- accumulateMetadata (oraccumulateProperty)
- contributeMetadata (orcontributeToProperty)
It can be tedious to type the genericMetadataKey.create<...>() for a key that you use internally to the schema. I'm worried people will just yolo andMetadataKey.create<any>(), should we add back an equivalent to the 2-parameter variant ofdefine?