Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: Correct description of lesson outcome#62710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
EmilianoGonzalezDev wants to merge1 commit intoangular:main
base:main
Choose a base branch
Loading
fromEmilianoGonzalezDev:patch-1

Conversation

EmilianoGonzalezDev

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprovepullapprovebot requested a review frommgechevJuly 18, 2025 15:28
Copy link
Member

@JeanMecheJeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this

@JeanMecheJeanMeche removed the request for review frommgechevJuly 18, 2025 21:18
@JeanMecheJeanMeche added action: mergeThe PR is ready for merge by the caretaker target: patchThis PR is targeted for the next patch release labelsJul 18, 2025
@@ -103,7 +103,7 @@ In your IDE:
Then, save the changes you made to`app.ts`.

1. If you stopped the`ng serve` command from step 1, in the**Terminal** window of your IDE, run`ng serve` again.
1. Open your browser and navigate to`localhost:4200` and confirm that the app builds without error and displays*Hello world* in the title and body of your app:
1. Open your browser and navigate to`localhost:4200` and confirm that the app builds without error and displays*Homes* in the title and*Hello world* in the body of your app:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wait, is it plural? LikeHomes, notHome?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@JeanMecheJeanMeche added action: cleanupThe PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: mergeThe PR is ready for merge by the caretaker labelsJul 18, 2025
@JeanMeche
Copy link
Member

Also we'll need you to reword the commit message to follow ourguidelines. It should adocs: ... commit. Thank you.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JeanMecheJeanMecheJeanMeche approved these changes

@kirjskirjskirjs requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
action: cleanupThe PR is in need of cleanup, either due to needing a rebase or in response to comments from reviewstarget: patchThis PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@EmilianoGonzalezDev@JeanMeche@kirjs
[8]ページ先頭
©2009-2025 Movatter.jp