- Notifications
You must be signed in to change notification settings - Fork26.4k
fix(core): Remove ignoreChangesOutsideZone option#62700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
atscott wants to merge1 commit intoangular:mainChoose a base branch fromatscott:removeIgnoreChangesOutsideZone
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+3 −80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This option was introduced out of caution as a way for developers to opt out ofthe new behavior in v18 which scheduled change detection even whenevents happened outside the NgZone. After monitoring the results post-release, wehave determined that this feature is working as desired and do not believe itshould ever be disabled by setting this option to `true`.This option was deprecated in v18.2, less than 3 months after it wasintroduced in v18. We do not really expect it to be used.BREAKING CHANGE: `ignoreChangesOutsideZone` is no longer available as anoption for configuring ZoneJS change detection behavior.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
area: coreIssues related to the framework runtime detected: breaking changePR contains a commit with a breaking change target: majorThis PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option was introduced out of caution as a way for developers to opt out of the new behavior in v18 which scheduled change detection even when events happened outside the NgZone. After monitoring the results post-release, we have determined that this feature is working as desired and do not believe it should ever be disabled by setting this option to
true
.This option was deprecated in v18.2, less than 3 months after it was introduced in v18. We do not really expect it to be used.
BREAKING CHANGE:
ignoreChangesOutsideZone
is no longer available as an option for configuring ZoneJS change detection behavior.