Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(devtools): make the component metadata menu more prominent#62685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hawkgs wants to merge2 commits intoangular:main
base:main
Choose a base branch
Loading
fromhawkgs:devtools/cmp-metadata-menu

Conversation

hawkgs
Copy link
Member

@hawkgshawkgs commentedJul 17, 2025
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

The menu content requires additional work but this should at least make it more prominent to the end user.

  • Add an arrow icon to indicate that this is an expansion panel.
  • Reduce the active area, which toggles the menu, to the text only. This will prevent the menu from expanding if you click the header which handles the cases when you misclick the "Show Signal Graph" button.
CollapsedExpanded
Screenshot 2025-07-17 at 15 38 50Screenshot 2025-07-18 at 10 03 05

michael-small reacted with thumbs up emoji
@hawkgshawkgs requested a review fromJeanMecheJuly 17, 2025 12:55
@ngbotngbotbot added this to theBacklog milestoneJul 17, 2025
@hawkgshawkgs marked this pull request as draftJuly 17, 2025 14:09
Add an arrow icon to indicate that this is an expansion panel. Reduce the active area (which toggles the menu) to the text only.
@hawkgshawkgsforce-pushed thedevtools/cmp-metadata-menu branch 2 times, most recently from74b1d14 to61c89a4CompareJuly 18, 2025 07:04
@hawkgs
Copy link
MemberAuthor

@JeanMeche, I added the reference icons and decided to do some changes to the menu. Additionally, I've added a new commit which creates thedocs-ref-button component that represents this same icon since there are several instances of such doc references in the app.

Used for external Angular docs links.
@hawkgshawkgsforce-pushed thedevtools/cmp-metadata-menu branch from61c89a4 tob4b5bb4CompareJuly 18, 2025 07:10
@hawkgshawkgs marked this pull request as ready for reviewJuly 18, 2025 07:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JeanMecheJeanMecheJeanMeche approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

2 participants
@hawkgs@JeanMeche

[8]ページ先頭

©2009-2025 Movatter.jp