- Notifications
You must be signed in to change notification settings - Fork26.4k
refactor(core): Only log the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MO…#62658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…DE warning onceThis reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warningis logged. This warning is especially spammy in tests.
JeanMeche commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Fwiw, this error being spammy is what lead me to investigate and land#62596. |
@JeanMeche that’s a fair point. I think one motivation for making it less spammy is that I would actually encourage and expect more Zoneless tests during migration (or even not). With Zoneless becoming the default, it may be that only a few tests truly need to test something specific to the ZoneJs integration but the rest can/should potentially operate in Zoneless mode by default but not necessarily require two splitting those out into a different test target. I also don’t think the original intent was to log on every test execution but for it to log once on app load. I could see this both ways though… |
…DE warning once
This reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warning is logged. This warning is especially spammy in tests.