Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(core): Only log the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MO…#62658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
atscott wants to merge1 commit intoangular:main
base:main
Choose a base branch
Loading
fromatscott:zonelesswarningless

Conversation

atscott
Copy link
Contributor

…DE warning once

This reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warning is logged. This warning is especially spammy in tests.

…DE warning onceThis reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warningis logged. This warning is especially spammy in tests.
@atscottatscott added the target: patchThis PR is targeted for the next patch release labelJul 15, 2025
@angular-robotangular-robotbot added the area: coreIssues related to the framework runtime labelJul 15, 2025
@ngbotngbotbot added this to theBacklog milestoneJul 15, 2025
@JeanMeche
Copy link
Member

JeanMeche commentedJul 15, 2025
edited
Loading

Fwiw, this error being spammy is what lead me to investigate and land#62596.
I see some kind of value of it being spammy, it's a huge FIXME.

@atscott
Copy link
ContributorAuthor

@JeanMeche that’s a fair point. I think one motivation for making it less spammy is that I would actually encourage and expect more Zoneless tests during migration (or even not).

With Zoneless becoming the default, it may be that only a few tests truly need to test something specific to the ZoneJs integration but the rest can/should potentially operate in Zoneless mode by default but not necessarily require two splitting those out into a different test target.

I also don’t think the original intent was to log on every test execution but for it to log once on app load.

I could see this both ways though…

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: coreIssues related to the framework runtimetarget: patchThis PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

2 participants
@atscott@JeanMeche

[8]ページ先頭

©2009-2025 Movatter.jp