- Notifications
You must be signed in to change notification settings - Fork26.4k
feat(core): render ARIA property bindings as attributes#62630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would expect at least to have some new compliance tests (probably inpackages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings
).
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Good suggestion, thanks. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Reviewed-for: fw-security
Allow binding to ARIA attributes using property binding syntax _without_the `attr.` prefix. For example, `[aria-label]="expr"` is now valid, andequivalent to `[ariaLabel]="expr"`. Both examples bind to either amatching input or the `aria-label` HTML attribute, rather than the`ariaLabel` DOM property.Binding ARIA properties as attributes will ensure they are renderedcorrectly on the server, where the emulated DOM may not correctlyreflect ARIA properties as attributes.Reuse the DOM schema registry from the compiler to map property names intype check blocks.
Allow binding to ARIA attributes using property binding syntaxwithout the
attr.
prefix. For example,[aria-label]="expr"
is now valid, and equivalent to[ariaLabel]="expr"
. Both examples bind to either a matching input or thearia-label
HTML attribute, rather than theariaLabel
DOM property.Binding ARIA properties as attributes will ensure they are rendered correctly on the server, where the emulated DOM may not correctly reflect ARIA properties as attributes.