Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(core): render ARIA property bindings as attributes#62630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
leonsenft wants to merge2 commits intoangular:main
base:main
Choose a base branch
Loading
fromleonsenft:aria-property

Conversation

leonsenft
Copy link
Contributor

Allow binding to ARIA attributes using property binding syntaxwithout theattr. prefix. For example,[aria-label]="expr" is now valid, and equivalent to[ariaLabel]="expr". Both examples bind to either a matching input or thearia-label HTML attribute, rather than theariaLabel DOM property.

Binding ARIA properties as attributes will ensure they are rendered correctly on the server, where the emulated DOM may not correctly reflect ARIA properties as attributes.

AndrewKushnir reacted with thumbs up emojimichael-small and AndrewKushnir reacted with heart emoji
@angular-robotangular-robotbot added detected: featurePR contains a feature commit area: coreIssues related to the framework runtime labelsJul 14, 2025
@ngbotngbotbot added this to theBacklog milestoneJul 14, 2025
Copy link
Member

@JeanMecheJeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would expect at least to have some new compliance tests (probably inpackages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings).

leonsenft reacted with thumbs up emoji
@leonsenft
Copy link
ContributorAuthor

I would expect at least to have some new compliance tests (probably inpackages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings).

Good suggestion, thanks. Done!

Copy link
Member

@josephperrottjosephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Reviewed-for: fw-security

Allow binding to ARIA attributes using property binding syntax _without_the `attr.` prefix. For example, `[aria-label]="expr"` is now valid, andequivalent to `[ariaLabel]="expr"`. Both examples bind to either amatching input or the `aria-label` HTML attribute, rather than the`ariaLabel` DOM property.Binding ARIA properties as attributes will ensure they are renderedcorrectly on the server, where the emulated DOM may not correctlyreflect ARIA properties as attributes.Reuse the DOM schema registry from the compiler to map property names intype check blocks.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@crisbetocrisbetocrisbeto approved these changes

@josephperrottjosephperrottjosephperrott approved these changes

@AndrewKushnirAndrewKushnirAndrewKushnir approved these changes

@JeanMecheJeanMecheAwaiting requested review from JeanMeche

@jelbournjelbournAwaiting requested review from jelbourn

Assignees
No one assigned
Labels
area: coreIssues related to the framework runtimedetected: featurePR contains a feature commit
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

5 participants
@leonsenft@JeanMeche@crisbeto@josephperrott@AndrewKushnir

[8]ページ先頭

©2009-2025 Movatter.jp