- Notifications
You must be signed in to change notification settings - Fork26.7k
Xss fix#40136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Xss fix#40136
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Reviewed-for: fw-security
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for the fix@mhevery 👍
(just left a couple minor comments related to comments, nothing critical)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Escape the content of the strings so that it can be safely inserted into a comment node.The issue is that HTML does not specify any way to escape comment end text inside the comment.`<!-- The way you close a comment is with "-->". -->`. Above the `"-->"` is meant to be textnot an end to the comment. This can be created programmatically through DOM APIs.```div.innerHTML = div.innerHTML```One would expect that the above code would be safe to do, but it turns out that because commenttext is not escaped, the comment may contain text which will prematurely close the commentopening up the application for XSS attack. (In SSR we programmatically create comment nodes whichmay contain such text and expect them to be safe.)This function escapes the comment text by looking for the closing char sequence `-->` and replaceit with `-_-_>` where the `_` is a zero width space `\u200B`. The result is that if a commentcontains `-->` text it will render normally but it will not cause the HTML parser to close thecomment.
| */ | ||
| constEND_COMMENT=/-->/g; | ||
| constEND_COMMENT_ESCAPED='-\u200B-\u200B>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OOC, why use two\u200Bs? Wouldn't--\u200B> also work?
Escape the content of the strings so that it can be safely inserted into a comment node.The issue is that HTML does not specify any way to escape comment end text inside the comment.`<!-- The way you close a comment is with "-->". -->`. Above the `"-->"` is meant to be textnot an end to the comment. This can be created programmatically through DOM APIs.```div.innerHTML = div.innerHTML```One would expect that the above code would be safe to do, but it turns out that because commenttext is not escaped, the comment may contain text which will prematurely close the commentopening up the application for XSS attack. (In SSR we programmatically create comment nodes whichmay contain such text and expect them to be safe.)This function escapes the comment text by looking for the closing char sequence `-->` and replaceit with `-_-_>` where the `_` is a zero width space `\u200B`. The result is that if a commentcontains `-->` text it will render normally but it will not cause the HTML parser to close thecomment.PRClose#40136
This issue has been automatically locked due to inactivity. Read more about ourautomatic conversation locking policy. This action has been performed automatically by a bot. |
Escape the content of the strings so that it can be safely inserted into a comment node.
The issue is that HTML does not specify any way to escape comment end text inside the comment.
<!-- The way you close a comment is with "-->". -->. Above the"-->"is meant to be text not an end to the comment. This can be created programmatically through DOM APIs.One would expect that the above code would be safe to do, but it turns out that because comment text is not escaped, the comment may contain text which will prematurely close the comment opening up the application for XSS attack. (In SSR we programmatically create comment nodes which may contain such text and expect them to be safe.)
This function escapes the comment text by looking for the closing char sequence
-->and replace it with-_-_>where the_is a zero width space\u200B. The result is that if a comment contains-->text it will render normally but it will not cause the HTML parser to close the comment.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information