- Notifications
You must be signed in to change notification settings - Fork26.7k
perf(core): usengDevMode to tree-shakecheckNoChanges#39964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AndrewKushnir commentedDec 3, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@arturovt, thanks for creating PRs to improve tree-shaking 👍 I'd like to propose an idea to group all commits from other PRs (except the one that is already marked for merge) into a single PR (while keeping changes in separate commits). That should help review these changes as a whole and would simplify the process of landing these changes. Thank you. |
@arturovt another benefit is that you may need to update payload sizes for test/demo apps (reducing the size), so there might be code conflicts that you would need to resolve multiple times... |
Yeah that makes sense. I was just thinking that it's a bad idea to have changes, that affect different packages, in 1 PR. |
This commit adds `ngDevMode` guard to run `checkNoChanges` onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The `ngDevMode` flag helps to tree-shake this code from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds ngDevMode guard to show warnings onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake these warnings from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds ngDevMode guard to show warning onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake this warning from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds `ngDevMode` guard to call `_ngModelWarning` onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The `ngDevMode` flag helps to tree-shake this function from production builds(since it will act as no-op, in dev mode everything will work as it works right now)to decrease production bundle size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for grouping commits into a single PR@arturovt 👍
The changes look good, just left a comment were I believe we'd still need to useisDevMode() check. Could you please have a look when you get a chance?
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for addressing the feedback@arturovt 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
reviewed-for: global-approvers
This commit adds ngDevMode guard to show warnings onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake these warnings from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964
This commit adds ngDevMode guard to show warning onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake this warning from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964
This commit adds `ngDevMode` guard to call `_ngModelWarning` onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The `ngDevMode` flag helps to tree-shake this function from production builds(since it will act as no-op, in dev mode everything will work as it works right now)to decrease production bundle size.PRClose#39964
This commit adds `ngDevMode` guard to run `checkNoChanges` onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The `ngDevMode` flag helps to tree-shake this code from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964
This commit adds ngDevMode guard to show warnings onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake these warnings from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964
This commit adds ngDevMode guard to show warning onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake this warning from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964
This commit adds `ngDevMode` guard to call `_ngModelWarning` onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The `ngDevMode` flag helps to tree-shake this function from production builds(since it will act as no-op, in dev mode everything will work as it works right now)to decrease production bundle size.PRClose#39964
This issue has been automatically locked due to inactivity. Read more about ourautomatic conversation locking policy. This action has been performed automatically by a bot. |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
PR Type
Does this PR introduce a breaking change?