Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(platform-browser-dynamic): exportJitCompilerFactory#20478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ocombe
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[X] Feature

What is the current behavior?

TheJitCompilerFactory is not exported in Angular v5

Issue Number:#20125

What is the new behavior?

JitCompilerFactory is now exported by theplatform-browser-dynamic package

Does this PR introduce a breaking change?

[x] No

VSmirnov17, Torqode, and JLHwung reacted with hooray emoji
@ocombeocombe added area: coreIssues related to the framework runtime action: reviewThe PR is still awaiting reviews from at least one requested reviewer target: majorThis PR is targeted for the next major release labelsNov 16, 2017
@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch 5 times, most recently from9b99a6b to77e952dCompareNovember 16, 2017 14:03
@angularangular deleted a comment frommary-poppinsNov 16, 2017
@angularangular deleted a comment frommary-poppinsNov 16, 2017
@VSmirnov17
Copy link

@ocombe Hello.

Update packages angular on version 5.1.0.beta1.

Try to import:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic";

TypeScript error:has no exported member 'JitCompilerFactory'

Autoimport WebStorm set:
import {JitCompilerFactory} from "@angular/platform-browser-dynamic/src/compiler_factory";

When I try to build:

ERROR in ./src/app/bootstrap/providers.tsModule not found: Error: Can't resolve '@angular/platform-browser-dynamic/src/compiler_factory' in '/home/vsmirnov/Desktop/angular5/proj/src/app/bootstrap' @ ./src/app/bootstrap/providers.ts 19:0-92 @ ./src/app/modules/app.module.ts @ ./src/main.ts @ multi (webpack)-dev-server/client?http://localhost:4200 ./src/main.tsChild html-webpack-plugin for "index.html":     1 asset       1 modulewebpack: Failed to compile.

@ocombe
Copy link
ContributorAuthor

Well yes, this PR has not been merged yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be experimental, not stable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same here. This should be experimental.

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch from77e952d tocc67834CompareNovember 17, 2017 17:39
@ocombeocombe requested a review frommheveryNovember 17, 2017 17:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am concerned that the constructor is public. Can we add/* @internal */ to it?

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch fromcc67834 tobbaa3f9CompareNovember 17, 2017 18:53
@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch 2 times, most recently from4ad8234 tof32441fCompareNovember 17, 2017 20:58
@mary-poppins
Copy link

You can preview f32441f athttps://pr20478-f32441f.ngbuilds.io/.

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch fromf32441f to1081950CompareNovember 17, 2017 21:25
@angularangular deleted a comment frommary-poppinsNov 17, 2017
@angularangular deleted a comment frommary-poppinsNov 17, 2017
@angularangular deleted a comment frommary-poppinsNov 17, 2017
@angularangular deleted a comment frommary-poppinsNov 17, 2017
@mary-poppins
Copy link

You can preview 1081950 athttps://pr20478-1081950.ngbuilds.io/.

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch from1081950 to35b67fcCompareNovember 17, 2017 22:08
@mary-poppins
Copy link

You can preview 35b67fc athttps://pr20478-35b67fc.ngbuilds.io/.

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch from35b67fc to62bc3deCompareNovember 17, 2017 22:51
@mary-poppins
Copy link

You can preview 62bc3de athttps://pr20478-62bc3de.ngbuilds.io/.

@VSmirnov17
Copy link

Good day!
When to wait for the merger?

@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch 2 times, most recently fromab252c0 toe2024c5CompareNovember 21, 2017 13:57
@ocombeocombeforce-pushed thefeat/#20125-jit-compiler-factory branch frome2024c5 to892caa7CompareNovember 21, 2017 15:00
@angularangular deleted a comment frommary-poppinsNov 21, 2017
@mary-poppins
Copy link

You can preview892caa7 athttps://pr20478-892caa7.ngbuilds.io/.

@ocombeocombe added action: mergeThe PR is ready for merge by the caretaker and removed action: reviewThe PR is still awaiting reviews from at least one requested reviewer labelsNov 22, 2017
@ocombeocombe deleted the feat/#20125-jit-compiler-factory branchJanuary 19, 2018 09:40
@angular-automatic-lock-bot

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about ourautomatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botbot locked and limited conversation to collaboratorsSep 13, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@mheverymheverymhevery approved these changes

@chuckjazchuckjazchuckjaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakerarea: coreIssues related to the framework runtimecla: yestarget: majorThis PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ocombe@VSmirnov17@mary-poppins@mhevery@chuckjaz@googlebot

[8]ページ先頭

©2009-2025 Movatter.jp