- Notifications
You must be signed in to change notification settings - Fork26.7k
feat(platform-browser-dynamic): exportJitCompilerFactory#20478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9b99a6b to77e952dCompareVSmirnov17 commentedNov 17, 2017
@ocombe Hello. Update packages angular on version 5.1.0.beta1. Try to import: TypeScript error: Autoimport WebStorm set: When I try to build: |
Well yes, this PR has not been merged yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be experimental, not stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here. This should be experimental.
77e952d tocc67834CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am concerned that the constructor is public. Can we add/* @internal */ to it?
cc67834 tobbaa3f9Compare4ad8234 tof32441fComparemary-poppins commentedNov 17, 2017
You can preview f32441f athttps://pr20478-f32441f.ngbuilds.io/. |
f32441f to1081950Comparemary-poppins commentedNov 17, 2017
You can preview 1081950 athttps://pr20478-1081950.ngbuilds.io/. |
1081950 to35b67fcComparemary-poppins commentedNov 17, 2017
You can preview 35b67fc athttps://pr20478-35b67fc.ngbuilds.io/. |
35b67fc to62bc3deComparemary-poppins commentedNov 17, 2017
You can preview 62bc3de athttps://pr20478-62bc3de.ngbuilds.io/. |
VSmirnov17 commentedNov 20, 2017
Good day! |
ab252c0 toe2024c5Comparee2024c5 to892caa7Comparemary-poppins commentedNov 21, 2017
You can preview892caa7 athttps://pr20478-892caa7.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about ourautomatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
JitCompilerFactoryis not exported in Angular v5Issue Number:#20125
What is the new behavior?
JitCompilerFactoryis now exported by theplatform-browser-dynamicpackageDoes this PR introduce a breaking change?