Commite95cd2a

basherr

authored and

thePunderWoman

committed

fix(animations): replace copy of query selector node-list from "spread" to "for" (#39646)

For element queries that return sufficiently large NodeListobjects, using spread syntax to populate the results arraycauses a RangeError due to the call stack limit being reached.This commit updates the code to use regular "for" loop instead.Fixes#38551.PRClose#39646

1 parent6dc74fd commite95cd2aCopy full SHA for e95cd2a

File tree

1 file changed

+11

-1

lines changed

packages/animations/browser/src/render
- shared.ts

1 file changed

+11

-1

lines changed

`‎packages/animations/browser/src/render/shared.ts‎`

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,17 @@ if (_isNode \|\| typeof Element !== 'undefined') {`
`183`	`183`	`_query=(element:any,selector:string,multi:boolean):any[]=>{`
`184`	`184`	`letresults:any[]=[];`
`185`	`185`	`if(multi){`
`186`		`-results.push(...element.querySelectorAll(selector));`
	`186`	`+// DO NOT REFACTOR TO USE SPREAD SYNTAX.`
	`187`	`+// For element queries that return sufficiently large NodeList objects,`
	`188`	`+// using spread syntax to populate the results array causes a RangeError`
	`189`	+// due to the call stack limit being reached. `Array.from` can not be used
	`190`	`+// as well, since NodeList is not iterable in IE 11, see`
	`191`	`+// https://developer.mozilla.org/en-US/docs/Web/API/NodeList`
	`192`	`+// More info is available in #38551.`
	`193`	`+constelems=element.querySelectorAll(selector);`
	`194`	`+for(leti=0;i<elems.length;i++){`
	`195`	`+results.push(elems[i]);`
	`196`	`+}`
`187`	`197`	`}else{`
`188`	`198`	`constelm=element.querySelector(selector);`
`189`	`199`	`if(elm){`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite95cd2a

File tree

1 file changed

1 file changed

`‎packages/animations/browser/src/render/shared.ts‎`

0 commit comments