Commit72aad32

arturovt

authored and

mhevery

committed

perf(animations): usengDevMode to tree-shake warning (#39964)

This commit adds ngDevMode guard to show warning onlyin dev mode (similar to how things work in other parts of Ivy runtime code).The ngDevMode flag helps to tree-shake this warning from production builds(in dev mode everything will work as it works right now) to decrease production bundle size.PRClose#39964

1 parentbf3de9b commit72aad32Copy full SHA for 72aad32

File tree

1 file changed

+11

-12

lines changed

packages/animations/browser/src/render/css_keyframes
- css_keyframes_driver.ts

1 file changed

+11

-12

lines changed

`‎packages/animations/browser/src/render/css_keyframes/css_keyframes_driver.ts‎`

Lines changed: 11 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ const TAB_SPACE = ' ';`
`21`	`21`	`exportclassCssKeyframesDriverimplementsAnimationDriver{`
`22`	`22`	`private_count=0;`
`23`	`23`	`privatereadonly_head:any=document.querySelector('head');`
`24`		`-private_warningIssued=false;`
`25`	`24`
`26`	`25`	`validateStyleProperty(prop:string):boolean{`
`27`	`26`	`returnvalidateStyleProperty(prop);`
`@@ -79,8 +78,8 @@ export class CssKeyframesDriver implements AnimationDriver {`
`79`	`78`	`animate(`
`80`	`79`	`element:any,keyframes:ɵStyleData[],duration:number,delay:number,easing:string,`
`81`	`80`	`previousPlayers:AnimationPlayer[]=[],scrubberAccessRequested?:boolean):AnimationPlayer{`
`82`		`-if(scrubberAccessRequested){`
`83`		`-this._notifyFaultyScrubber();`
	`81`	`+if((typeofngDevMode==='undefined'\|\|ngDevMode)&&scrubberAccessRequested){`
	`82`	`+notifyFaultyScrubber();`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`constpreviousCssKeyframePlayers=<CssKeyframesPlayer[]>previousPlayers.filter(`
`@@ -117,15 +116,6 @@ export class CssKeyframesDriver implements AnimationDriver {`
`117`	`116`	`player.onDestroy(()=>removeElement(kfElm));`
`118`	`117`	`returnplayer;`
`119`	`118`	`}`
`120`		`-`
`121`		`-private_notifyFaultyScrubber(){`
`122`		`-if(!this._warningIssued){`
`123`		`-console.warn(`
`124`		`-'@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',`
`125`		`-' visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');`
`126`		`-this._warningIssued=true;`
`127`		`-}`
`128`		`-}`
`129`	`119`	`}`
`130`	`120`
`131`	`121`	`functionflattenKeyframesIntoStyles(keyframes:null\|{[key:string]:any}\|`
`@@ -146,3 +136,12 @@ function flattenKeyframesIntoStyles(keyframes: null\|{[key: string]: any}\|`
`146`	`136`	`functionremoveElement(node:any){`
`147`	`137`	`node.parentNode.removeChild(node);`
`148`	`138`	`}`
	`139`	`+`
	`140`	`+letwarningIssued=false;`
	`141`	`+functionnotifyFaultyScrubber():void{`
	`142`	`+if(warningIssued)return;`
	`143`	`+console.warn(`
	`144`	`+'@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',`
	`145`	`+' visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');`
	`146`	`+warningIssued=true;`
	`147`	`+}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit72aad32

File tree

1 file changed

1 file changed

`‎packages/animations/browser/src/render/css_keyframes/css_keyframes_driver.ts‎`

0 commit comments