Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit61c89a4

Browse files
committed
refactor(devtools): introduce doc-ref-button
Used for external Angular docs links.
1 parentad97b0f commit61c89a4

16 files changed

+96
-65
lines changed

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ ng_project(
4646
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/defer-view:defer-view_rjs",
4747
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view:property-view_rjs",
4848
"//devtools/projects/ng-devtools/src/lib/shared/button:button_rjs",
49+
"//devtools/projects/ng-devtools/src/lib/shared/docs-ref-button:docs-ref-button_rjs",
4950
"//devtools/projects/protocol:protocol_rjs",
5051
],
5152
)

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/component-metadata.component.html

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,13 @@
33
@if (viewEncapsulation()) {
44
<li>
55
View Encapsulation:<spanclass="meta-data">{{ viewEncapsulation() }}</span>
6-
<a
7-
href="https://angular.dev/api/core/ViewEncapsulation"
8-
target="_blank"
9-
matTooltip="Open docs reference"
10-
>
11-
<mat-icon>open_in_new</mat-icon>
12-
</a>
6+
<ng-docs-ref-buttondocs="view-encapsulation"/>
137
</li>
148
}
159
@if (changeDetectionStrategy()) {
1610
<li>
1711
Change Detection Strategy:<spanclass="meta-data">{{ changeDetectionStrategy() }}</span>
18-
<a
19-
href="https://angular.dev/api/core/ChangeDetectionStrategy"
20-
target="_blank"
21-
matTooltip="Open docs reference"
22-
>
23-
<mat-icon>open_in_new</mat-icon>
24-
</a>
12+
<ng-docs-ref-buttondocs="change-detection"/>
2513
</li>
2614
}
2715
</ul>

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/component-metadata.component.scss

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@
2323
font-weight:bold;
2424
}
2525

26-
mat-icon {
27-
width:16px;
28-
height:16px;
29-
font-size:16px;
30-
vertical-align:bottom;
26+
ng-docs-ref-button {
3127
margin-left:0.125rem;
3228
}
3329
}

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/component-metadata.component.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
inject,
1515
input,
1616
}from'@angular/core';
17-
import{MatIcon}from'@angular/material/icon';
1817

1918
import{
2019
AngularDirectiveMetadata,
@@ -23,13 +22,13 @@ import {
2322
}from'../../../../../../protocol';
2423

2524
import{ElementPropertyResolver}from'../property-resolver/element-property-resolver';
26-
import{MatTooltip}from'@angular/material/tooltip';
25+
import{DocsRefButtonComponent}from'../../../shared/docs-ref-button/docs-ref-button.component';
2726

2827
@Component({
2928
selector:'ng-component-metadata',
3029
templateUrl:'./component-metadata.component.html',
3130
styleUrls:['./component-metadata.component.scss'],
32-
imports:[MatIcon,MatTooltip],
31+
imports:[DocsRefButtonComponent],
3332
changeDetection:ChangeDetectionStrategy.OnPush,
3433
})
3534
exportclassComponentMetadataComponent{

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ ng_project(
6363
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/index-forest:index-forest_rjs",
6464
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-resolver:property-resolver_rjs",
6565
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/resolution-path:resolution-path_rjs",
66+
"//devtools/projects/ng-devtools/src/lib/shared/docs-ref-button:docs-ref-button_rjs",
6667
"//devtools/projects/protocol:protocol_rjs",
6768
],
6869
)

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/property-view-body.component.html

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,7 @@
77
<mat-expansion-panel-headercollapsedHeight="28px"expandedHeight="28px">
88
<mat-panel-title>
99
Injected Services
10-
<a
11-
href="https://angular.dev/guide/di"
12-
target="_blank"
13-
class="documentation"
14-
matTooltip="Open docs reference"
15-
(click)="$event.stopPropagation()"
16-
>
17-
<mat-iconclass="docs-link">open_in_new</mat-icon>
18-
</a>
10+
<ng-docs-ref-buttondocs="dependency-injection"/>
1911
</mat-panel-title>
2012
</mat-expansion-panel-header>
2113
<ng-injected-services[controller]="controller()"/>

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/property-view-body.component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
@use'../../../../../styles/typography';
22

33
:host {
4+
ng-docs-ref-button {
5+
margin-left:0.125rem;
6+
}
7+
8+
/* FRAGILE*/
49
::ng-deep {
510
mat-expansion-panel {
611
border-radius:unset!important;

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/property-view-body.component.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ import {
2525
}from'../../property-resolver/directive-property-resolver';
2626
import{FlatNode}from'../../property-resolver/element-property-resolver';
2727
import{PropertyViewTreeComponent}from'./property-view-tree.component';
28-
import{MatIcon}from'@angular/material/icon';
29-
import{MatTooltip}from'@angular/material/tooltip';
3028
import{MatExpansionModule}from'@angular/material/expansion';
3129
import{DependencyViewerComponent}from'./dependency-viewer.component';
30+
import{DocsRefButtonComponent}from'../../../../shared/docs-ref-button/docs-ref-button.component';
3231

3332
@Component({
3433
selector:'ng-property-view-body',
@@ -37,11 +36,10 @@ import {DependencyViewerComponent} from './dependency-viewer.component';
3736
imports:[
3837
MatExpansionModule,
3938
CdkDropList,
40-
MatTooltip,
41-
MatIcon,
4239
forwardRef(()=>InjectedServicesComponent),
4340
CdkDrag,
4441
PropertyViewTreeComponent,
42+
DocsRefButtonComponent,
4543
],
4644
changeDetection:ChangeDetectionStrategy.OnPush,
4745
})

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ ng_project(
2828
"//:node_modules/d3",
2929
"//:node_modules/rxjs",
3030
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-providers:injector-providers_rjs",
31+
"//devtools/projects/ng-devtools/src/lib/shared/docs-ref-button:docs-ref-button_rjs",
3132
"//devtools/projects/ng-devtools/src/lib/shared/split:responsive-split_rjs",
3233
"//devtools/projects/ng-devtools/src/lib/shared/split:split_rjs",
3334
"//devtools/projects/ng-devtools/src/lib/shared/tree-visualizer-host:tree-visualizer-host_rjs",

‎devtools/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-tree.component.html

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,7 @@
3030
<divclass="injector-hierarchy">
3131
<h2>
3232
<span>Environment Hierarchy</span>
33-
<a
34-
class="hierarchy-ref"
35-
href="https://angular.dev/guide/di/hierarchical-dependency-injection#types-of-injector-hierarchies"
36-
target="_blank"
37-
>
38-
<mat-iconmatTooltip="Open docs reference"> open_in_new</mat-icon>
39-
</a>
33+
<ng-docs-ref-buttondocs="injector-hierarchies"/>
4034
</h2>
4135
<sectionclass="injector-graph">
4236
<ng-tree-visualizer-host
@@ -50,13 +44,7 @@ <h2>
5044
<divclass="injector-hierarchy">
5145
<h2>
5246
<span>Element Hierarchy</span>
53-
<a
54-
class="hierarchy-ref"
55-
href="https://angular.dev/guide/di/hierarchical-dependency-injection#types-of-injector-hierarchies"
56-
target="_blank"
57-
>
58-
<mat-iconmatTooltip="Open docs reference"> open_in_new</mat-icon>
59-
</a>
47+
<ng-docs-ref-buttondocs="injector-hierarchies"/>
6048
</h2>
6149
<sectionclass="injector-graph">
6250
<ng-tree-visualizer-host#elementTreea11yTitle="Element hierarchy visualization"/>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp