Commit9f76fb6

authored and

committed

refactor(forms): tree-shakengControlStatusHost andngGroupStatusHost

This commit removes `ngGroupStatusHost` variable because it's a side-effect, ending up preserving `ngControlStatusHost` and `ngGroupStatusHost`.

1 parent4441437 commit9f76fb6Copy full SHA for 9f76fb6

File tree

-10

lines changed

-10

lines changed

Lines changed: 0 additions & 2 deletions

Lines changed: 0 additions & 2 deletions

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,11 +81,6 @@ export const ngControlStatusHost = {`
`81`	`81`	`'[class.ng-pending]':'isPending',`
`82`	`82`	`};`
`83`	`83`
`84`		`-exportconstngGroupStatusHost={`
`85`		`- ...ngControlStatusHost,`
`86`		`-'[class.ng-submitted]':'isSubmitted',`
`87`		`-};`
`88`		`-`
`89`	`84`	`/**`
`90`	`85`	`*@description`
`91`	`86`	`* Directive automatically applied to Angular form controls that sets CSS classes`
`@@ -135,7 +130,13 @@ export class NgControlStatus extends AbstractControlStatus {`
`135`	`130`	`@Directive({`
`136`	`131`	`selector:`
`137`	`132`	`'[formGroupName],[formArrayName],[ngModelGroup],[formGroup],[formArray],form:not([ngNoForm]),[ngForm]',`
`138`		`-host:ngGroupStatusHost,`
	`133`	`+// Note: having this object here to ensure that the spread assignment is not considered`
	`134`	+// a side-effect, ending up preserving `ngControlStatusHost` and `ngGroupStatusHost`.
	`135`	+// Do not move it to a separate const (`ngGroupStatusHost`).
	`136`	`+host:{`
	`137`	`+ ...ngControlStatusHost,`
	`138`	`+'[class.ng-submitted]':'isSubmitted',`
	`139`	`+},`
`139`	`140`	`standalone:false,`
`140`	`141`	`})`
`141`	`142`	`exportclassNgControlStatusGroupextendsAbstractControlStatus{`

Comments

(0)