- Notifications
You must be signed in to change notification settings - Fork7
Soft shutdown review comments 2#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Soft shutdown review comments 2#3
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/runtime/classmanager.cs Outdated
| @@ -251,7 +251,6 @@ private static void InitClassBase(Type type, ClassBase impl) | |||
| // TODO: deprecate __overloads__ soon... | |||
| Runtime.PyDict_SetItemString(dict, "__overloads__", ctors.pyHandle); | |||
| Runtime.PyDict_SetItemString(dict, "Overloads", ctors.pyHandle); | |||
| ctors.DecrRefCount(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It leaks.
Would it be better if you just switch to old commit rather than add more revert commits? |
When serializing wrapper objects on domain shutdownAddresses comment:pythonnet#958 (comment)
Fixes an issue where there is no current thread state on shutdown.Also fixes a comment in Runtime.Initialize
... of WaitForFullGCComplete on runtime shutdownAddresses comment:pythonnet#958 (comment)
e0f2bed to80a7644Comparecodecov-commenter commentedSep 10, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## soft-shutdown #3 +/- ##============================================== Coverage 86.25% 86.25% ============================================== Files 1 1 Lines 291 291 ============================================== Hits 251 251 Misses 40 40
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG