Commit3988ff7

committed

refactor(config): remove hide_taskbar option and related functionality

- hide_taskbar is not part of the YASB anymore. There was a many issues with it and it was not working as expected.

1 parent6f2590c commit3988ff7Copy full SHA for 3988ff7

File tree

-37

lines changed

-37

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ All valid options for the widgets are listed on the widgets page.`
`15`	`15`	\|`watch_stylesheet`\| boolean\|`true`\| Reload bar when style is changed.\|
`16`	`16`	\|`watch_config`\| boolean\|`true`\| Reload bar when config is changed.\|
`17`	`17`	\|`debug`\| boolean\|`false`\| Enable debug mode to see more logs\|
`18`		-\|`hide_taskbar`\| boolean\|`false`\| Hide Windows taskbar from all screens. Note: for better performance set taskbar auto-hide.\|
`19`	`18`	\|`env_file`\| string\|`None`\| Load environment variables from file.\|
`20`	`19`
`21`	`20`

Lines changed: 1 addition & 21 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`importctypes.wintypes`
`2`	`2`	`fromcore.event_enumsimportEvent`
`3`		`-importlogging`
`4`	`3`
`5`	`4`	`user32=ctypes.windll.user32`
`6`	`5`	`user32.SetWinEventHook.restype=ctypes.wintypes.HANDLE`
`@@ -19,7 +18,6 @@`
`19`	`18`	`ctypes.wintypes.DWORD`
`20`	`19`	`)`
`21`	`20`
`22`		`-`
`23`	`21`	`classWinEvent(Event):`
`24`	`22`	`"""`
`25`	`23`	`Win32user Event Constants`
`@@ -101,22 +99,4 @@ class WinEvent(Event):`
`101`	`99`	`EventUIAEventIdStart=0x4E00`
`102`	`100`	`EventUIAEventIdEnd=0x4EFF`
`103`	`101`	`EventUIAPropIdStart=0x7500`
`104`		`-EventUIAPropIdEnd=0x75FF`
`105`		`-`
`106`		`-`
`107`		`-classWindowsTaskbar:`
`108`		`-@staticmethod`
`109`		`-defhide(state,debug):`
`110`		`-SW_SHOWNORMAL=1`
`111`		`-SW_HIDE=0`
`112`		`-user32=ctypes.WinDLL('user32',use_last_error=True)`
`113`		`-try:`
`114`		`-forclass_namein ["Shell_TrayWnd","Shell_SecondaryTrayWnd"]:`
`115`		`-taskbar=user32.FindWindowW(class_name,None)`
`116`		`-iftaskbar:`
`117`		`-user32.ShowWindow(taskbar,SW_HIDEifstateelseSW_SHOWNORMAL)`
`118`		`-ifdebug:`
`119`		`-logging.info(f"Taskbar{taskbar} found and{'hide'ifstateelse'restore'}.")`
`120`		`-exceptExceptionase:`
`121`		`-ifdebug:`
`122`		`-logging.error(f"Failed to hide taskbar:{e}")`
	`102`	`+EventUIAPropIdEnd=0x75FF`

Lines changed: 0 additions & 5 deletions

Lines changed: 2 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,16 +13,13 @@`
`13`	`13`	`importsettings`
`14`	`14`	`importctypes`
`15`	`15`	`importctypes.wintypes`
`16`		`-fromcore.utils.win32.windowsimportWindowsTaskbar`
`17`	`16`	`fromdotenvimportload_dotenv`
`18`	`17`
`19`	`18`	`logging.getLogger('asyncio').setLevel(logging.WARNING)`
`20`	`19`
`21`	`20`	`defmain():`
`22`	`21`	`config,stylesheet=get_config_and_stylesheet()`
`23`		`-globalhide_taskbar`
`24`		`-hide_taskbar=config['hide_taskbar']`
`25`		`-`
	`22`	`+`
`26`	`23`	`ifconfig['debug']:`
`27`	`24`	`settings.DEBUG=True`
`28`	`25`	`logging.info("Debug mode enabled.")`
`@@ -61,22 +58,17 @@ def stop_observer():`
`61`	`58`	`ifobserver:`
`62`	`59`	`observer.stop()`
`63`	`60`	`observer.join()`
`64`		`-ifhide_taskbar:`
`65`		`-WindowsTaskbar.hide(False,settings.DEBUG)`
	`61`	`+`
`66`	`62`	`app.aboutToQuit.connect(stop_observer)`
`67`	`63`
`68`	`64`	`withloop:`
`69`		`-ifhide_taskbar:`
`70`		`-WindowsTaskbar.hide(True,settings.DEBUG)`
`71`	`65`	`loop.run_forever()`
`72`	`66`
`73`	`67`
`74`	`68`	`if__name__=="__main__":`
`75`	`69`	`init_logger()`
`76`	`70`	`base_excepthook=sys.excepthook`
`77`	`71`	`defexception_hook(exctype,value,traceback):`
`78`		`-ifhide_taskbar:`
`79`		`-WindowsTaskbar.hide(False,settings.DEBUG)`
`80`	`72`	`EventService().clear()`
`81`	`73`	`logging.error("Unhandled exception",exc_info=value)`
`82`	`74`	`sys.exit(1)`

Comments

(0)