Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3bf31dd

Browse files
author
Álvaro Herrera
committed
Do a tiny bit of header file maintenance
Stop including utils/relcache.h in access/genam.h, and stop includinghtup_details.h in nodes/tidbitmap.h. Both these files (genam.h andtidbitmap.h) are widely used in other header files, so it's in our bestinterest that they remain as lean as reasonable.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/202509291356.o5t6ny2hoa3q@alvherre.pgsql
1 parentbb68cde commit3bf31dd

File tree

7 files changed

+9
-2
lines changed

7 files changed

+9
-2
lines changed

‎contrib/btree_gist/btree_bit.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include"utils/fmgrprotos.h"
99
#include"utils/sortsupport.h"
1010
#include"utils/varbit.h"
11+
#include"varatt.h"
1112

1213
/* GiST support functions */
1314
PG_FUNCTION_INFO_V1(gbt_bit_compress);

‎src/backend/nodes/tidbitmap.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
#include<limits.h>
4242

43+
#include"access/htup_details.h"
4344
#include"common/hashfn.h"
4445
#include"common/int.h"
4546
#include"nodes/bitmapset.h"

‎src/backend/utils/adt/network_spgist.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
#include"catalog/pg_type.h"
3838
#include"utils/fmgrprotos.h"
3939
#include"utils/inet.h"
40+
#include"varatt.h"
4041

4142

4243
staticintinet_spg_node_number(constinet*val,intcommonbits);

‎src/include/access/amapi.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
#include"access/cmptype.h"
1616
#include"access/genam.h"
1717
#include"access/stratnum.h"
18+
#include"nodes/nodes.h"
19+
#include"nodes/pg_list.h"
1820

1921
/*
2022
* We don't wish to include planner header files here, since most of an index

‎src/include/access/genam.h‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@
2020
#include"nodes/tidbitmap.h"
2121
#include"storage/buf.h"
2222
#include"storage/lockdefs.h"
23-
#include"utils/relcache.h"
2423
#include"utils/snapshot.h"
2524

2625
/* We don't want this file to depend on execnodes.h. */
2726
typedefstructIndexInfoIndexInfo;
2827
typedefstructTupleTableSlotTupleTableSlot;
2928

29+
/* or relcache.h */
30+
typedefstructRelationData*Relation;
31+
3032

3133
/*
3234
* Struct for statistics maintained by amgettuple and amgetbitmap

‎src/include/access/nbtree.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include"catalog/pg_index.h"
2323
#include"lib/stringinfo.h"
2424
#include"storage/bufmgr.h"
25+
#include"storage/dsm.h"
2526
#include"storage/shm_toc.h"
2627
#include"utils/skipsupport.h"
2728

‎src/include/nodes/tidbitmap.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#ifndefTIDBITMAP_H
2323
#defineTIDBITMAP_H
2424

25-
#include"access/htup_details.h"
2625
#include"storage/itemptr.h"
2726
#include"utils/dsa.h"
2827

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp