This repository was archived by the owner on Jul 29, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Show tooltip on dot as well#4274
Open
kelvinau wants to merge1 commit intoalmende:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The vis.js project is no longer being maintained. if You'd like this feature to be added, please reapply this PR tohttps://github.com/yotamberk/timeline-plus and I'll review it there. |
16 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
showTooltipsis enabled, items with titles will display a tooltip on mouseover. When there's no end time, a dot appears on the timeline. Use would intuitively look for the tooltip on the dot, but it is not shown when mouseover. This PR addstimeline-itemto the dot DOM and bindsverticalBackgroundwith the mouse events, so the mouseover logic also applies to the dot.Below is the effect after the changes:
