- Notifications
You must be signed in to change notification settings - Fork1.5k
Add support for graphviz edge "dir"#4202
base:develop
Are you sure you want to change the base?
Conversation
If the "dir" attribute is present in the edge, disable both arrows,and selectively re-enable them based on dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please also add documentation for this feature. I think somewhere near here:https://github.com/almende/vis/blob/develop/docs/network/edges.html#L193
It appears the only DOT-specific documentation is athttps://github.com/almende/vis/blob/develop/docs/network/index.html#L1568 -- I did add some examples tohttps://github.com/almende/vis/blob/develop/examples/network/data/dotLanguage/dotEdgeStyles.html -- perhaps just add some explicit language there specifying the mapping from DOT dir to vis.js arrows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
perhaps just add some explicit language there specifying the mapping from DOT dir to vis.js arrows?
I didn't realize that this is a DOT format feature.
LGTM
If the "dir" attribute is present in the edge, disable both arrows,
and selectively re-enable them based on dir.