- Notifications
You must be signed in to change notification settings - Fork582
python requests#175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
python requests#175
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JacksonTian commentedJan 21, 2019
把 requests 从覆盖率统计里去除吧。 |
JacksonTian commentedJan 21, 2019
你还可以分两步提交。 先把 requests 放到 vendored 目录下。 |
only add package requests;modify coverage
JacksonTian commentedJan 21, 2019
approveyer 和 travis 有 coverage 不统一的统计 |
Suvie277 commentedJan 22, 2019
覆盖率从结果上看已经排除了requests，且二者是统一的。但是页面上显示的结果一直不变 |
…ragemodify default_connect_timeoutadd .codecov.ymlmodify coverage
.appveyor.yml Outdated
| Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh | ||
| bash codecov.sh -f "coverage.xml" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
留那么多空格干嘛呢。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
这个地方的脚本 不太确定咋写，反复修改了几遍，没有注意多行空行的问题
codecov-io commentedJan 23, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #175 +/- ##=========================================- Coverage 89.05% 85.26% -3.8%========================================= Files 45 44 -1 Lines 2111 1608 -503 Branches 234 157 -77 =========================================- Hits 1880 1371 -509- Misses 197 223 +26+ Partials 34 14 -20
Continue to review full report at Codecov.
|
modify http_response.py;
modify client.py;
add package requests;
ignore InsecureRequestWarning