Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
[ui/core] GroupAttributes connection#2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
nicolas-lambert-tc wants to merge14 commits intodev/connectGroupAttrsChoose a base branch
base:dev/connectGroupAttrs
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[ui/core] GroupAttributes connection#2754
nicolas-lambert-tc wants to merge14 commits intodev/connectGroupAttrsfromdev/connectAttrs-and-avoid-cycle
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… Visually all edges are drawn
… are hidden. If any of the subAttributes is connected to another attribute, it disconnect the GroupAttribute. (Not yet recursive)
…butes are connected (edges are redirected to the next visible grpAttribute)
…connected ('{Node.grpAttribute}')…raph to have stable undo
…y to the attribute, and automatically handle undo for the attribute connections
…bute and handle the undo
codecovbot commentedJun 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@## dev/connectGroupAttrs #2754 +/- ##=========================================================+ Coverage 78.94% 79.27% +0.33%========================================================= Files 50 53 +3 Lines 6662 6829 +167 =========================================================+ Hits 5259 5414 +155- Misses 1403 1415 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
47deef3 to8d316bfCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR add the possibility to connect
GroupAttributebased on thisPR (From@cbentejac)It adds:
GroupAttribute connection link the subAttributes:
Features list
GroupAttributeconnectionGroupAttributeconnect automatically all subAttributesImplementation remarks