Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
[ui] [fix]: The focus on text components is now released on outside click#2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedJun 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@## develop #2740 +/- ##======================================== Coverage 77.14% 77.15% ======================================== Files 41 41 Lines 6165 6167 +2 ========================================+ Hits 4756 4758 +2 Misses 1409 1409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0bd696 tofeb8e0fComparefeb8e0f toc0fb672Comparec0fb672 to6e35205Compare
fabiencastan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Problem on copy/paste
Uh oh!
There was an error while loading.Please reload this page.
Description
Bug:
Clicking outside of a text component (a search filter in the example below), didn't release the focus.
Now the focus is stolen by the main.MouseArea component
Related PR
This is an other approach of the PR provided by@waaake:#2666
It avoid creating
MouseAreaon existing and future components.Implementation Details
It uses the eventFilter to only catch the mousePress events and clear focus each time an item have a focus at this step.
/!\ Having a python condition on each event can be time consuming.
It uses the
EventFilterand can have some performance cost, but because it directly filtered event by type()(not isinstance) , it should be imperceptible.