Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.5k
fix: migrate deprecated componentWillReceiveProps to componentDidUpdate#798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
18vikastg wants to merge1 commit intoalgorithm-visualizer:masterChoose a base branch from18vikastg:fix/deprecated-lifecycle-methods
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+108 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Replaced componentWillReceiveProps with componentDidUpdate in 6 components- Added proper prevProps comparison to prevent unnecessary updates- Ensures compatibility with React 17+ and future versionsResolves deprecation warnings and future-proofs the codebase.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several React component lifecycle methods to use
componentDidUpdateinstead of the deprecatedcomponentWillReceiveProps, and introduces persistent workspace state and improved event handling. These changes enhance code maintainability, user experience, and future compatibility.Lifecycle method modernization:
componentWillReceivePropswithcomponentDidUpdateinApp,Navigator,Player,FoldableAceEditor,VisualizationViewer, andToastContainercomponents to ensure compatibility with modern React best practices.[1][2][3][4][5][6]Workspace state persistence:
Appto load and persist workspace preferences (navigatorOpenedandworkspaceWeights) usinglocalStorage, so user layout choices are retained across sessions.[1][2]Event handling improvements:
Player, added keyboard shortcuts for play/pause (space), previous (left arrow), and next (right arrow) actions, and window resize handling, improving accessibility and usability. Also added cleanup for event listeners on unmount.Toast notification timing fix:
ToastContainerto correctly handle toast timeouts and cleanup, ensuring toasts disappear after the intended delay and preventing memory leaks.Editor folding logic refinement:
FoldableAceEditorso tracers are folded only when appropriate, reducing unnecessary operations.- Replaced componentWillReceiveProps with componentDidUpdate in 6 componentsResolves deprecation warnings and future-proofs the codebase.
This pull request refactors several React components to replace the deprecated
componentWillReceivePropslifecycle method with the recommendedcomponentDidUpdate. It also adds new workspace persistence features and keyboard shortcuts, improving user experience and code maintainability.Lifecycle method modernization
componentWillReceivePropswithcomponentDidUpdateinApp,Navigator,Player,ToastContainer,FoldableAceEditor, andVisualizationViewercomponents, ensuring compatibility with newer React versions and improving reliability.[1][2][3][4][5][6]Workspace persistence improvements
Appto load and persist workspace preferences such as navigator visibility and workspace weights usinglocalStorage, allowing users' UI state to be remembered across sessions.[1][2]Keyboard shortcut enhancements
Playerfor play/pause (space), previous (left arrow), and next (right arrow) actions, improving accessibility and user interaction.Resource management
PlayerandToastContainercomponents on unmount, preventing potential memory leaks.[1][2]Component-specific update logic
FoldableAceEditorandVisualizationViewerto correctly respond to prop changes by folding tracers or updating visualizations only when relevant data changes.[1][2]