Commit78842cf

authored and

committed

crypto: remove getDefaultEncoding()

Refs:nodejs#47182Refs:nodejs#47869Refs:nodejs#47943Refs:nodejs#47998Refs:nodejs#49140Refs:nodejs#49145Refs:nodejs#49167Refs:nodejs#49169PR-URL:nodejs#49170Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Filip Skokan <panva.ip@gmail.com>Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent64a5c01 commit78842cfCopy full SHA for 78842cf

File tree

-11

lines changed

-11

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,11 +75,6 @@ const {`
`75`	`75`	`constkHandle=Symbol('kHandle');`
`76`	`76`	`constkKeyObject=Symbol('kKeyObject');`
`77`	`77`
`78`		`-// TODO(tniessen): remove all call sites and this function`
`79`		`-functiongetDefaultEncoding(){`
`80`		`-return'buffer';`
`81`		`-}`
`82`		`-`
`83`	`78`	`// This is here because many functions accepted binary strings without`
`84`	`79`	`// any explicit encoding in older versions of node, and we don't want`
`85`	`80`	`// to break them unnecessarily.`
`@@ -555,7 +550,6 @@ module.exports = {`
`555`	`550`	`getCiphers,`
`556`	`551`	`getCurves,`
`557`	`552`	`getDataViewOrTypedArrayBuffer,`
`558`		`- getDefaultEncoding,`
`559`	`553`	`getHashes,`
`560`	`554`	`kHandle,`
`561`	`555`	`kKeyObject,`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,10 +11,6 @@ const {`
`11`	`11`
`12`	`12`	`conststream=require('stream');`
`13`	`13`
`14`		`-const{`
`15`		`- getDefaultEncoding,`
`16`		`-}=require('internal/crypto/util');`
`17`		`-`
`18`	`14`	`module.exports=LazyTransform;`
`19`	`15`
`20`	`16`	`functionLazyTransform(options){`
`@@ -29,7 +25,7 @@ function makeGetter(name) {`
`29`	`25`	`this._writableState.decodeStrings=false;`
`30`	`26`
`31`	`27`	`if(!this._options\|\|!this._options.defaultEncoding){`
`32`		`-this._writableState.defaultEncoding=getDefaultEncoding();`
	`28`	`+this._writableState.defaultEncoding='buffer';// TODO(tniessen): remove`
`33`	`29`	`}`
`34`	`30`
`35`	`31`	`returnthis[name];`

Comments

(0)