- Notifications
You must be signed in to change notification settings - Fork707
Exact path matching command line option#980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SeeStarz commentedFeb 15, 2025
Now that it comes to shell integration I don't think I am qualified to progress any further, I do hope this will be somewhat useful if anyone has similar ideas. The added feature is |
oriongonza commentedFeb 16, 2025
Your git history is whack since you merged instead of rebasing |
SeeStarz commentedFeb 17, 2025
I completely missed that, thanks! |
| #[clap(long, value_hint =ValueHint::DirPath, value_name ="path")] | ||
| pubexclude:Option<String>, | ||
| /// Only match exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd spend a bit more time explaining this feature. This is what will show up in--help
| }); | ||
| ifletSome(idx) = idx{ | ||
| components = components.drain(0..idx).collect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This... is convoluted to say the least.
SeeStarz commentedSep 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi it's been a while, average random guy making a PR am i right. Also thanks for reading my PR and reviewing it, and sorry it took so long to reply. Anyways the best feature explanation i came up with while being consistent with others is Upon reconsideration, it's apparent that my implementation doesn't play nicely with any queries with For this reason i'm changing this PR back to draft. My personal interpretation concludes that the easiest way to do so is modifying |
Proof of concept feature improvement related to#260
This adds a new option to allow exact matching of sub path (the ones in between slashes). e.g.
zoxide query rustmatchesrustbut notrust-analyzer. However I haven't been able to understand how to integrate this option into CLI options, as such this pull request isn't complete yet.I personally think just being able to exact match directories would help with QoL especially since the ones most vulnerable to regex matching is short names anyways.
Any feedback would be welcome!