- Notifications
You must be signed in to change notification settings - Fork26.8k
ESLint v 9x Compatibility Changes#3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "test":"npm run --silent test:config && npm run --silent test:config:base", | ||
| "test:config":"cd packages/eslint-config-airbnb; npm test", | ||
| "test:config:base":"cd packages/eslint-config-airbnb-base; npm test", | ||
| "test:config":"cd packages/eslint-config-airbnb && npm test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why is this needed?cd should never fail regardless
| }, | ||
| "peerDependencies": { | ||
| "eslint":"^7.32.0 || ^8.2.0", | ||
| "eslint":"^9.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is a breaking change. please limit yourself to things that work with eslint 7+.
| // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-curly-newline.md | ||
| 'react/jsx-curly-newline':['error',{ | ||
| // https://eslint.style/rules/jsx/jsx-curly-newline | ||
| '@stylistic/jsx/jsx-curly-newline':['error',{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
adding a new peer dep is a breaking change; we won't be doing that.
Uh oh!
There was an error while loading.Please reload this page.
These are the changes for ESLint 9.x branch compatibility.
Made all changes needed that I could find to run with new ESLint versions including removing some older packages and dependencies. Similarly some packages were added. Please see changes to see
package.jsonfiles.This maybe too large of a change and may need to be broken down further.
I was limited to Windows for testing.