- Notifications
You must be signed in to change notification settings - Fork26.8k
fix whitespace module execSync under Windows with no shebang#3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
zaycker wants to merge2 commits intoairbnb:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a duplicate of#2706. Please don't file duplicate PRs - if one is outdated, you can comment on that PR with your branch and maintainers can pull it in. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
fixes#2700
In case the eslint version is 8,
whitespace.jsfile tries to executewhitespace-async.jsfile.whitespace-async.jsfile starts with shebang header#!/usr/bin/env nodewhich doesn't work under Windows.It cannot be executed right away without definition of interpreter.
In case we try to execute it with
execSyncor any other fork tool it opens up a dialog for choosing a program to open the .js file.It requires explicit definition of
nodeinterpreter at the place of execution.windowsHideoption prevents opening ofcmdwindow during execution and it is ignored under non-Windows systems.there is another PR which is outdated. made a fresh one