Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed some dead links in the resource section of readme#2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Yash-Ambekar wants to merge3 commits intoairbnb:master
base:master
Choose a base branch
Loading
fromYash-Ambekar:readmeDeadLinks

Conversation

Yash-Ambekar
Copy link

Fixed some dead links in the resource section of ReadMe when I was going through some of the linked resources.

matheusfelipeog, wshishir, and LucaSofronie reacted with thumbs up emoji
README.md Outdated
**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](http://audio.javascriptair.com/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this not available using https?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Yash-Ambekar you marked this as resolved, but it's not resolved. can you answer the question?

@Yash-Ambekar
Copy link
Author

@ljharb@matheusfelipeog please review my changes and guide me how can I improve upon the changes.

@cclypeatus
Copy link

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

ljharb reacted with eyes emoji

@ljharbljharb marked this pull request as draftDecember 13, 2023 18:21
@Yash-Ambekar
Copy link
Author

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

Yeah providing web archive links seems like a good idea to me.@ljharb please can you give your opinion on this.

@ljharb
Copy link
Collaborator

I'm fine with an archive.org link for any links that are dead; if wealso want to reference a new URL that seems to have the same content, that's fine too.

- [LatestECMA spec](https://tc39.github.io/ecma262/)
- [ExploringJS](https://exploringjs.com/)
- [ES6 Compatibility Table](https://compat-table.github.io/compat-table/es6/)
- [ES6 Compatibility Table](https://kangax.github.io/compat-table/es6/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this should be reverted, the compat table lives in an org now

**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](https://web.archive.org/web/20190626004622/https://javascriptair.com/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Both the links point to the same source , so why this url change required ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like the website was down before, but is back up now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbljharb left review comments

+3 more reviewers

@matheusfelipeogmatheusfelipeogmatheusfelipeog left review comments

@anandfreshanandfreshanandfresh requested changes

@NyaundiNyaundiNyaundi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@Yash-Ambekar@cclypeatus@ljharb@anandfresh@matheusfelipeog@Nyaundi

[8]ページ先頭

©2009-2025 Movatter.jp