- Notifications
You must be signed in to change notification settings - Fork26.8k
Code made compatible with Airbnb style guide#2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
0o001 wants to merge4 commits intoairbnb:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
Changes from1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Add array destructuring
https://github.com/airbnb/javascript#destructuring--arrayAnd severities array put inside the getSeverity function
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit83fcc83d97e4368667c8332d15f12384a5f71c1a
There are no files selected for viewing
7 changes: 3 additions & 4 deletionspackages/eslint-config-airbnb-base/whitespace-async.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletionspackages/eslint-config-airbnb-base/whitespace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,9 +9,9 @@ if (CLIEngine) { | ||
| const baseConfig = require('.'); | ||
| function getSeverity(ruleConfig) { | ||
| const severities = ['off', 'warn', 'error']; | ||
0o001 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| if (Array.isArray(ruleConfig)) { | ||
| return getSeverity(ruleConfig[0]); | ||
| } | ||
| @@ -27,8 +27,7 @@ if (CLIEngine) { | ||
| const baseRules = cli.getConfigForFile(require.resolve('./')).rules; | ||
| entries(baseRules).forEach((rule) => { | ||
| const [ruleName, ruleConfig] = rule; | ||
| const severity = getSeverity(ruleConfig); | ||
| if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') { | ||
7 changes: 3 additions & 4 deletionspackages/eslint-config-airbnb/whitespace-async.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,9 +6,9 @@ const { ESLint } = require('eslint'); | ||
| const baseConfig = require('.'); | ||
| const whitespaceRules = require('./whitespaceRules'); | ||
| function getSeverity(ruleConfig) { | ||
| const severities = ['off', 'warn', 'error']; | ||
0o001 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| if (Array.isArray(ruleConfig)) { | ||
| return getSeverity(ruleConfig[0]); | ||
| } | ||
| @@ -27,8 +27,7 @@ async function onlyErrorOnRules(rulesToError, config) { | ||
| const baseRules = (await cli.calculateConfigForFile(require.resolve('./'))).rules; | ||
| entries(baseRules).forEach((rule) => { | ||
| const [ruleName, ruleConfig] = rule; | ||
| const severity = getSeverity(ruleConfig); | ||
| if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') { | ||
7 changes: 3 additions & 4 deletionspackages/eslint-config-airbnb/whitespace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.