- Notifications
You must be signed in to change notification settings - Fork26.8k
Code made compatible with Airbnb style guide#2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
https://github.com/airbnb/javascript#destructuring--arrayAnd severities array put inside the getSeverity function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is enforcing this change?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I wanted to align the used codes with the format recommended in Airbnb's own style guide. |
Right, but our own eslint rules in this project should be enforcing that, rather than doing it manually. |
Add arrays bracket newline
https://github.com/airbnb/javascript#arrays--bracket-newline
Add array destructuring
https://github.com/airbnb/javascript#destructuring--array
And severities array put inside the getSeverity function