lines-around-directive rule should replaced with padding-line-between…#2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

HemanthPaila wants to merge1 commit intoairbnb:master

base:master

Choose a base branch

fromHemanthPaila:HemanthPaila-Fixed

Draft

lines-around-directive rule should replaced with padding-line-between…#2756

HemanthPaila wants to merge1 commit intoairbnb:masterfromHemanthPaila:HemanthPaila-Fixed

Conversation

Copy link

HemanthPaila commentedApr 2, 2023

fixed issuelines-around-directive rule should replaced withpadding-line-between-statements #2689

ljharb requested changes

Apr 2, 2023

View reviewed changes

Copy link

Collaborator

ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Make sure if your editor is set up to run prettier or any autoformatter, that you disable those - formatters should only be ran on a repo where the repo is set up to use one explicitly

packages/eslint-config-airbnb-base/rules/style.js Outdated

		// https://eslint.org/docs/rules/array-bracket-newline
		// TODO: enable? semver-major
		'array-bracket-newline':['off','consistent'],// object option alternative: { multiline: true, minItems: 3 }
		"array-bracket-newline":["off","consistent"],// object option alternative: { multiline: true, minItems: 3 }