Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork17
ci: migrate to GH actions#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- mostly duplicate what I have in [react-signature-canvas](https://github.com/agilgur5/react-signature-canvas/blob/main/.github/workflows/ci.yml) - update LTS Node versions to 18.x and 20.x - comment out linting step for now as `ts-standard` hasn't been configured in this repo- add `tsc` and `test:coverage` scripts for CI - had to specify `--noEmit` for now, the whole build system will need to be revamped later- replace Travis badge with GH Actions badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
awesome, tests pass on the new GH Actions CI!
had to modify branch protection for the new checks and had to reactivate Codecov (which is glitching on themaster ->main branch rename), but otherwise seems to be working 🙂
thankfully was pretty straightforward when copying existing code!
Summary
Migrate over to GH Actions from Travis
Details
mostly duplicate what I have inreact-signature-canvas
ts-standardhasn't been configured in this repoadd
tscandtest:coveragescripts for CI--noEmitfor now, the whole build system will need to be revamped laterreplace Travis badge with GH Actions badge