Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

deps: more permissive mst peerDep, update mst devDep#33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
agilgur5 merged 5 commits intoagilgur5:mainfrombarbalex:master
Jul 13, 2023

Conversation

@barbalex
Copy link
Contributor

@barbalexbarbalex commentedJul 12, 2023•
edited by agilgur5
Loading

resolves#32

@agilgur5agilgur5 changed the titleFix upstream dependency conflictUpdate mst peerDepJul 13, 2023
Copy link
Owner

@agilgur5agilgur5 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You were able to test and confirm that this was working on MST 5, right? Seems like there weren't too many changes in4.0.0 or5.0.0 thankfully

The CI on this repo is still on Travis, so I need to migrate that to GH Actions to get it to run on each PR

Copy link
Owner

@agilgur5agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should update the devDeps as well to make sure MST 5 is tested against. That'll require an update of the MobX devDep as well

@agilgur5
Copy link
Owner

The CI on this repo is still on Travis, so I need to migrate that to GH Actions to get it to run on each PR

CI has been migrated as of#34 now. If you rebase offmain, that should get it to run on your PR

@agilgur5agilgur5 changed the titleUpdate mst peerDepdeps: update mst peerDepJul 13, 2023
@barbalex
Copy link
ContributorAuthor

You were able to test and confirm that this was working on MST 5, right?

Yes, in two of my projects it has been running flawlessly for years

agilgur5 reacted with thumbs up emojiagilgur5 reacted with hooray emoji

@barbalex
Copy link
ContributorAuthor

Not sure if I did all that's needed. Please check

agilgur5 reacted with thumbs up emoji

barbalexand others added3 commitsJuly 13, 2023 12:32
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
- to make sure that we test on MST 5 et al
- I thought `push` covered PRs as well, maybe that got changed  - or it was always only for my own PRs? not sure as it worked in repos I don't own either...
@agilgur5agilgur5 changed the titledeps: update mst peerDepdeps: more permissive mst peerDep, update mst devDepJul 13, 2023
- was getting errors on MST and MobX internal types  - current TS direction is to use `skipLibCheck` as the default    - c.f.microsoft/TypeScript-Website@625e1c5
Copy link
Owner

@agilgur5agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

updated devDeps myself, LGTM now! all tests still passing 🙂

also had to update some one-line CI settings

@codecov

This comment was marked as resolved.

@agilgur5agilgur5 merged commit7a6e8e0 intoagilgur5:mainJul 13, 2023
@agilgur5
Copy link
Owner

Released in0.1.4.

Thanks for your continued contribution@barbalex!

@agilgur5agilgur5 added the scope: dependenciesPull requests that update a dependency file labelJul 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@agilgur5agilgur5agilgur5 approved these changes

Assignees

No one assigned

Labels

scope: dependenciesPull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mst peerDep is outdated

2 participants

@barbalex@agilgur5
[8]ページ先頭
©2009-2025 Movatter.jp