NotificationsYou must be signed in to change notification settings
Fork17
Star86

Commit6b1dd3b

committed

(hotfix): jsonify shouldn't set false to true

- meant to use the previous code as an alternative to using a default arg, but `!jsonify` detects false (etc), not just undefined - switched to just using a default arg, which was what I originally used before moving defaults outside of the destructuring - alternative is to check `typeof jsonify === 'undefined'` instead - default args seem to provide better typings in my experience, so stick to that for now

1 parent10d4cd7 commit6b1dd3bCopy full SHA for 6b1dd3b

File tree

1 file changed

-2

lines changed

src
- index.ts

1 file changed

-2

lines changed

`‎src/index.ts‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export interface IOptions {`
`14`	`14`	`typeStrToAnyMap={[key:string]:any}`
`15`	`15`
`16`	`16`	`exportconstpersist:IArgs=(name,store,options={})=>{`
`17`		`-let{storage, jsonify, whitelist, blacklist}=options`
	`17`	`+let{storage, jsonify=true, whitelist, blacklist}=options`
`18`	`18`
`19`	`19`	`// use AsyncLocalStorage by default (or if localStorage was passed in)`
`20`	`20`	`if(`
`@@ -30,7 +30,6 @@ export const persist: IArgs = (name, store, options = {}) => {`
`30`	`30`	'engine via the `storage:` option.')
`31`	`31`	`}`
`32`	`32`
`33`		`-if(!jsonify){jsonify=true}// default to true like mobx-persist`
`34`	`33`	`constwhitelistDict=arrToDict(whitelist)`
`35`	`34`	`constblacklistDict=arrToDict(blacklist)`
`36`	`35`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit6b1dd3b

File tree

1 file changed

1 file changed

`‎src/index.ts‎`

0 commit comments