- Notifications
You must be signed in to change notification settings - Fork28
Add extract variable#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b6ffa55 toe5263dcComparefc344b0 to61bf093Compare61bf093 to29cb21bComparezaxxx commentedDec 10, 2023
hi man@alquerci , huge thank you for this, so glad I found it! apparently it's not going to get merged, so if you don't mind, I'm just gonna use your fork in my packer config 😅 I've been using vim.lsp.buf.code_action refactor.extract.expression, but it doesn't have the courtesy of asking me for a variable's name and it's asynchronous, so I can't easily chain it with PhpRenameLocalVariable... a workaround is to use something like vim.wait(2000) between those commands... ugh.. but your work is exactly what I need and will be a huge time saver in the long run. So, thanks again! |
alquerci commentedDec 10, 2023
Hello@zaxxx, I am glad that my work can help you. It helps me a lot in daily work bases. Since one year, a lot of stuff has been done. All of them has been done regarding issues or needs I caught. Some refactorings are never used and others are overused. |
Uh oh!
There was an error while loading.Please reload this page.
Hi,
Firstly, thanks for this great Vim plugin.
Look at the documentation to see the details.
Tested on VIM 8.1
In order to add proof that the code work as it should, I choose to usehttps://github.com/junegunn/vader.vim as test runner.
Why we need this ?
Extract Variable is part of the must-have tools of a programmer as this refactoring is done too many times.
From "Clean Craftsmanship: Disciplines, Standards, and Ethics (Robert C. Martin Series) (English Edition)" written by Robert C. Martin