Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork43
Fix System Error on Python 3.13 and Windows#457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gaborbernat commentedJun 28, 2024
I also do not have one :D used the Windows GHA to catch this :D |
Okay, I tested on Windows in CI too, in#458. The test suite is not ready to run on Windows without more work, so I’m going to merge and release this without any test for now. |
Please give 2.14.2 a try! |
Fixes#456.
The relevant crash from the test log actually seems to be the initial failure:
PyObject_GetAttrStringfails to getclock_gettimeandclock_gettime_nson Windows because they only exist on Unix. It returnsNULLand each time sets theAttributeErroras the current error.patch_if_neededdid not clear this, leading to Python's call check to raise aSystemErrorcaused by theAttributeError, making time-machine fail to start travelling.I'm not sure which exact change in Python made this failure occur, so far it seems the
SystemErrorshould have been raised on older versions too. Ah well.@gaborbernat I haven’t got a Windows setup for verifying this on - would you mind trying this on your test suite?