Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix System Error on Python 3.13 and Windows#457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
adamchainz merged 1 commit intomainfromwindows_system_error
Jun 29, 2024

Conversation

@adamchainz
Copy link
Owner

Fixes#456.

The relevant crash from the test log actually seems to be the initial failure:

AttributeError: module 'time' has no attribute 'clock_gettime_ns'The above exception was the direct cause of the following exception:...>       _time_machine.patch_if_needed()E       SystemError: <built-in function patch_if_needed> returned a result with an exception set

PyObject_GetAttrString fails to getclock_gettime andclock_gettime_ns on Windows because they only exist on Unix. It returnsNULL and each time sets theAttributeError as the current error.patch_if_needed did not clear this, leading to Python's call check to raise aSystemError caused by theAttributeError, making time-machine fail to start travelling.

I'm not sure which exact change in Python made this failure occur, so far it seems theSystemError should have been raised on older versions too. Ah well.

@gaborbernat I haven’t got a Windows setup for verifying this on - would you mind trying this on your test suite?

@gaborbernat
Copy link

@gaborbernat I haven’t got a Windows setup for verifying this on - would you mind trying this on your test suite?

I also do not have one :D used the Windows GHA to catch this :D

@adamchainz
Copy link
OwnerAuthor

Okay, I tested on Windows in CI too, in#458. The test suite is not ready to run on Windows without more work, so I’m going to merge and release this without any test for now.

@adamchainzadamchainz merged commitd205a63 intomainJun 29, 2024
@adamchainzadamchainz deleted the windows_system_error branchJune 29, 2024 09:15
@adamchainz
Copy link
OwnerAuthor

Please give 2.14.2 a try!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails on 3.13.0b2 Windows

3 participants

@adamchainz@gaborbernat

[8]ページ先頭

©2009-2025 Movatter.jp