Removes visibleI2CTargetRequest.close() method. AddsI2CTargetRequest.deinit(). Doesclose() anddeinit() inI2CTargetRequest.__exit__(). MakesI2CTargetRequest have a finalizer:__del__() callsdeinit().

I tried testing with the more extensive example in theI2CTarget documentation, which tries to write and then read a value to an I2C register. It did not work, but I could not get that example to work with 8.2.9 or 9.2.3 either.

@Neradoc if you or someone else would like to test this with some previously-working code, I would be grateful.

i2ctarget: Add deinit() to I2CTargetRequest; remove close()

7d3dd30

dhalbert force-pushed thei2ctargetrequest-deinit branch from17e24b8 to7d3dd30Compare

May 21, 2025 17:00

Copy link

Neradoc commentedMay 21, 2025•
edited
Loading

The following test code triggers the issue in 9.2.7 and works as expected with this PR.

Controller code (running on a tiny2350)

importboardimportrandomimporttimefromadafruit_bus_device.i2c_deviceimportI2CDevicei2c=board.STEMMA_I2C()device=I2CDevice(i2c,0x40)buffer=bytearray(1)whileTrue:try:withdevice:device.readinto(buffer)print(f"device responded with #{buffer[0]:02X}")time.sleep(1)withdevice:buffer[0]=random.randint(0,255)device.write(buffer)print(f"wrote to device: #{buffer[0]:02X}")time.sleep(1)exceptOSError:# target resetting or in errortime.sleep(1)

Target code (pro micro 2040) - that's the code being tested.

importboardfromi2ctargetimportI2CTargetmemory=0x55withI2CTarget(board.SCL,board.SDA, (0x40,))asdevice:whileTrue:i2c_target_request=device.request()ifnoti2c_target_request:continuewithi2c_target_request:ifi2c_target_request.is_read:print(f"read request: #{memory:02X}")buffer=memory.to_bytes(1)i2c_target_request.write(buffer)else:data=i2c_target_request.read(1)print(f"write request: #{data[0]:02X}")memory=data[0]

Could we have the call tocommon_hal_i2ctarget_i2c_target_close in deinit ? It is possible (though ill advised) to not use the context manager and call deinit manually, in which case I believe close wouldn't be called.
And then we could remove the custom__exit__.

Copy link

CollaboratorAuthor

dhalbert commentedMay 21, 2025

Could we have the call tocommon_hal_i2ctarget_i2c_target_close in deinit ? It is possible (though ill advised) to not use the context manager and call deinit manually, in which case I believe close wouldn't be called.
And then we could remove the custom__exit__.

I considered that, but wasn't sure if there was another use case. But I think not. I'll do that, yes, thanks.