Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork812
WIP: add an example of a bidirectional gRPC call via tonic#404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
lunar-debian wants to merge1 commit intoactix:mainChoose a base branch fromlunar-debian:tonic-bidirectional
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
robjtede commentedMar 6, 2022
If there's still interest in getting this PR in a state to merge we'd be interested. Otherwise, if there's no updates, I'll close it out in a couple weeks or so. |
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hi! This is an attempt to add an example of using actix and tonic together (#348) by integrating a client bidirectional gRPC call with other actors.
The proto provides an
Echoservice with anEchoRPC. It’s a bidirectional stream, sendingEchoRequestand receivedEchoReply. I haven’t written the corresponding server yet, but it should be easy enough.Anyway, this doesn’t build at the moment and I’m not sure to be on the right track…
The current idea is to have an
EchoService, looking like gRPC, responsible for maintaining a connection to the gRPC server.It accepts a
RunEchomessage to call the RPC and start anEchoRpcactor that would handle input/output for the bidirectional stream. Does it make sense to architecture things this way?Where I’m stuck is how to implement the actual call to the RPC (see the
RunEchohandler). I can’t find the proper way to integrate the call without lifetime issues. Any idea?I'm quite new to Rust, so I would be thankful for any other comments.
This PR is also missing a
README, which I would happily write after a validation of the general architecture by someone more knowledgeable with Actix and the general ecosystem.