Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve wording and "fix example" (remove 3.13) on testing against pre-release#979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
HarithaVattikuti merged 2 commits intoactions:mainfromyarikoptic:bf-example
Oct 14, 2025

Conversation

@yarikoptic
Copy link
Contributor

Description:

3.13 was added in a mass tune up in0b93645 , without adjusting the wording. With 3.13 listed there too, example does not really make much sense. So I decided to make it explicit in wording and remove 3.13, so whenever next refactoring to add 3.14 to be added to every line where 3.13 is -- this would not even come to attention

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

…e-releases3.13 was added in a mass tune up in0b93645 , withoutadjusting the wording. With 3.13 listed there too, example does not really make muchsense. So I decided to make it explicit in wording and remove 3.13, so whenever nextrefactoring to add 3.14 to be added to every line where 3.13 is -- this would noteven come to attention
@yarikopticyarikoptic requested a review froma team as acode ownerDecember 5, 2024 21:14
@gowridurgad
Copy link
Contributor

Hi@yarikoptic, thanks for improving the documentation!
Since Python 3.14 is now the current pre-release, could you please update both the explanatory paragraph and the matrix example to use "3.14" as the pre-release version instead of 3.12. This will make the example more relevant and accurately demonstrate how allow-prereleases works with an actual pre-release, rather than referencing 3.12, which is already generally available.

@gowridurgadgowridurgad self-assigned thisSep 22, 2025
@yarikoptic
Copy link
ContributorAuthor

Since here I am not adding a new documentation but rather providing minor tune up to already existing wording, which was potentially added whenallow-prereleases was added, IMHO would be best to keep exampleas is. Switching to 3.14 would invalidate added "in the past" and would then require such a PR later to make it again factually correct.

@gowridurgad
Copy link
Contributor

Hi@yarikoptic, To keep the original wording intact, it is suggested to only update the version number from 3.12 to 3.14 in the paragraph, like this:

Let’s say that Python 3.14 is not generally available, the following workflow will fallback to the most recent pre-release of Python 3.14.

And in the matrix, update the version list to:
python_version: ["3.14"]

This way, the example provides a concrete and current reference for configuring workflows with a real pre-release version, making it more practical and helpful for users.

CopilotAI review requested due to automatic review settingsSeptember 24, 2025 12:57
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR improves the documentation for theallow-prereleases feature by updating the example to use Python 3.14 instead of 3.13, making the pre-release scenario more realistic since 3.13 is now generally available.

  • Updates example version from 3.13 to 3.14 to better illustrate pre-release behavior
  • Adjusts wording to clarify this is a historical example of how the feature would work
  • Simplifies the matrix to focus on the single pre-release version being demonstrated

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

matrix:
os: [Ubuntu, Windows, macOS]
python_version: ["3.11", "3.12", "3.13"]
python_version: ["3.14"]
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@gowridurgad like this?

if you see how to improve further, please use suggestions
image
so we converge faster.

@HarithaVattikutiHarithaVattikuti merged commit18566f8 intoactions:mainOct 14, 2025
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@HarithaVattikutiHarithaVattikutiHarithaVattikuti approved these changes

@aparnajyothi-yaparnajyothi-yaparnajyothi-y approved these changes

@gowridurgadgowridurgadgowridurgad approved these changes

Assignees

@gowridurgadgowridurgad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yarikoptic@gowridurgad@HarithaVattikuti@aparnajyothi-y

[8]ページ先頭

©2009-2025 Movatter.jp