- Notifications
You must be signed in to change notification settings - Fork689
Throwing an error in getManifestFromRepo when the github API rate limiting response is a JSON object.#945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| } | ||
| return releases; | ||
| if (!releases.hasOwnProperty('documentation_url')){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Dist/index.js is not where these changes should be directly made.
This index.js is a form of webpack and gets auto-generated from the source files in thesrc directory.
Line 13 in70dcb22
| "release":"ncc build -o dist/setup src/setup-python.ts && ncc build -o dist/cache-save src/cache-save.ts && git add -f dist/", |
Fundamentially you're trying to update thegetManifestFromRepo function. That can be found here:
setup-python/src/install-python.ts
Lines 47 to 57 in70dcb22
| exportfunctiongetManifestFromRepo():Promise<tc.IToolRelease[]>{ | |
| core.debug( | |
| `Getting manifest from${MANIFEST_REPO_OWNER}/${MANIFEST_REPO_NAME}@${MANIFEST_REPO_BRANCH}` | |
| ); | |
| returntc.getManifestFromRepo( | |
| MANIFEST_REPO_OWNER, | |
| MANIFEST_REPO_NAME, | |
| AUTH, | |
| MANIFEST_REPO_BRANCH | |
| ); | |
| } |
That uses a function from the our tool-cache NPM package in the actions/toolkit repository. This is the actual place where the change would need to be made:https://github.com/actions/toolkit/blob/6dd369c0e648ed58d0ead326cf2426906ea86401/packages/tool-cache/src/tool-cache.ts#L589-L632
So upstream the change would need to be made totool-cache, a new version would then need to be published and then pulled into this repository/action.https://www.npmjs.com/package/@actions/tool-cache
I recommend submitting a PR tohttps://github.com/actions/toolkit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Appreciate the feedback on this issue. I'll investigate your recommendation.
mahabaleshwars commentedSep 24, 2024
Hello@Lavaerius, Are you planning to make modifications to this PR as per@konradpabjan's suggestion? Thank you! |
Lavaerius commentedSep 24, 2024
Yes, I'll look into that. |
Lavaerius commentedSep 25, 2024
I've submitted: |
Description:
Updates fail condition for getManifestFromRepo function to include instances when github responds with JSON body for API rate limiting, that is incorrectly handled.
Related issue:
#903
Check list: