- Notifications
You must be signed in to change notification settings - Fork689
Extend LIBRARY_PATH as well as LD_LIBRARY_PATH on Linux#909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tyrken commentedJul 12, 2024
While this PR has been tested and Works-For-Me (tm),actions/python-versions#275 sounds like it would be a better fix if it works as advertised, gets released & the pythons rebuilt... |
| if (!libPath.split(':').includes(pyLibPath)) { | ||
| core.exportVariable('LD_LIBRARY_PATH', pyLibPath + libPath); | ||
| } | ||
| ensurePathInEnvVar('LIBRARY_PATH', pyLibPath); |
jaswanthikollaJul 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TBH, I wouldn't go with the route ofLD_LIBRARY_PATH as some systems ( including containers) doesn't allow it as it's a security issue.
Description:
On Linux we already set
LD_LIBRARY_PATHto thelibfolder under the extracted Python, to allow running apps to findlibPythonand other libraries. This is not enough to letgccfind those libraries during compilation, e.g. as some Python dependencies do when installing. For this we also need to add the lib folder to theLIBRARY_PATHenv-var.Related issue:
Shouldfix#275
Not sure if the suggestion to override
AGENT_TOOLSDIRECTORYfor Linux if the existingadvanced-docs is needed any more. It certainly didn't work for me and between the two*LIBRARY_PATHenv-vars that should be enough.Check list: