Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Include Python version in pip cache key#303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MaksimZhukov merged 2 commits intoactions:mainfromhugovk:pip-cache-python-version
Jan 31, 2022

Conversation

@hugovk
Copy link
Contributor

@hugovkhugovk commentedDec 16, 2021•
edited
Loading

Description:

Like we do for pipenv, let's include the Python version in the pip cache key.

Without it, PyPy jobs continually build wheels from source, which is slow, and they never make it into the pip cache because there are prebuilt wheels for CPython jobs already in the cache.

Related issue:

Fixes#288.
Fixes#304.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Molkree, achimnol, and simonhkswan reacted with thumbs up emoji
@dmitry-shibanov
Copy link
Contributor

Hello@hugovk. Thank you for your pull request. Could you please sync with the main branch and run thenpm run release command.

@hugovkhugovkforce-pushed thepip-cache-python-version branch from45cf4cf to95b9974CompareDecember 24, 2021 17:51
@hugovk
Copy link
ContributorAuthor

Done! Afternpm install andnpm run release, there were unstaged changes inpackage-lock.json, but I didn't commit it, just the auto-stageddist/setup/index.js changed.

@hugovkhugovkforce-pushed thepip-cache-python-version branch fromeba23d0 to7ccd7e6CompareJanuary 1, 2022 11:47
@hugovk
Copy link
ContributorAuthor

Not sure why these are failing, they pass on my fork:https://github.com/hugovk/setup-python/actions/runs/1643387334

@dmitry-shibanov
Copy link
Contributor

Hello@hugovk. Sorry for the late response. Could please sync with the main branch. Builds should be fixed.

@hugovkhugovkforce-pushed thepip-cache-python-version branch from7ccd7e6 tofcd6854CompareJanuary 26, 2022 16:02
@hugovk
Copy link
ContributorAuthor

Rebased and CI passes, thanks! ✅

simonhkswan reacted with hooray emoji

@MaksimZhukovMaksimZhukov merged commitba33a69 intoactions:mainJan 31, 2022
@MaksimZhukov
Copy link
Contributor

Hello@hugovk! Thank you for the contribution!

hugovk reacted with rocket emoji

@hugovkhugovk deleted the pip-cache-python-version branchJanuary 31, 2022 10:43
tdfacer pushed a commit to ifit/setup-python that referenced this pull requestOct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@dmitry-shibanovdmitry-shibanovdmitry-shibanov approved these changes

@MaksimZhukovMaksimZhukovMaksimZhukov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pip caching should include Python version in cache key PyPy3 wheels not uploaded to cache -> very slow builds

3 participants

@hugovk@dmitry-shibanov@MaksimZhukov
[8]ページ先頭
©2009-2025 Movatter.jp